Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760393AbcDEXpl (ORCPT ); Tue, 5 Apr 2016 19:45:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:57411 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbcDEXpk (ORCPT ); Tue, 5 Apr 2016 19:45:40 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,445,1455004800"; d="scan'208";a="948837318" Date: Tue, 5 Apr 2016 16:44:25 -0700 From: Vinod Koul To: Stanimir Varbanov Cc: Rob Herring , Mark Rutland , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Sinan Kaya , Pramod Gurav Subject: Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property Message-ID: <20160405234425.GD11586@vkoul-mobl.iind.intel.com> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 452 Lines: 15 On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote: > Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++ > drivers/dma/qcom/bam_dma.c | 7 +++++++ The binding should be a separate patch.. > > + bdev->controlled_remotely = of_property_read_bool(pdev->dev.of_node, > + "qcom,controlled-remotely"); > + we need some defaults here, how will this work with boards withe older DT. -- ~Vinod