Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760821AbcDEX7Z (ORCPT ); Tue, 5 Apr 2016 19:59:25 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:46291 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbcDEX7X (ORCPT ); Tue, 5 Apr 2016 19:59:23 -0400 Subject: Re: [PATCH 08/20] mfd: lp3943: Use devm_mfd_add_devices() for mfd_device registration To: Laxman Dewangan References: <1459856912-17859-1-git-send-email-ldewangan@nvidia.com> <1459856912-17859-9-git-send-email-ldewangan@nvidia.com> CC: , , , , , , , From: "Kim, Milo" Message-ID: <5704514E.3020603@ti.com> Date: Wed, 6 Apr 2016 08:59:10 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1459856912-17859-9-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1492 Lines: 47 On 4/5/2016 8:48 PM, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for mfd devices registration and get > rid of .remove callback to remove mfd devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Milo Kim Acked-by: Milo Kim > --- > drivers/mfd/lp3943.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/drivers/mfd/lp3943.c b/drivers/mfd/lp3943.c > index eecbb13..65a2a8f1 100644 > --- a/drivers/mfd/lp3943.c > +++ b/drivers/mfd/lp3943.c > @@ -123,16 +123,9 @@ static int lp3943_probe(struct i2c_client *cl, const struct i2c_device_id *id) > lp3943->mux_cfg = lp3943_mux_cfg; > i2c_set_clientdata(cl, lp3943); > > - return mfd_add_devices(dev, -1, lp3943_devs, ARRAY_SIZE(lp3943_devs), > - NULL, 0, NULL); > -} > - > -static int lp3943_remove(struct i2c_client *cl) > -{ > - struct lp3943 *lp3943 = i2c_get_clientdata(cl); > - > - mfd_remove_devices(lp3943->dev); > - return 0; > + return devm_mfd_add_devices(dev, -1, lp3943_devs, > + ARRAY_SIZE(lp3943_devs), > + NULL, 0, NULL); > } > > static const struct i2c_device_id lp3943_ids[] = { > @@ -151,7 +144,6 @@ MODULE_DEVICE_TABLE(of, lp3943_of_match); > > static struct i2c_driver lp3943_driver = { > .probe = lp3943_probe, > - .remove = lp3943_remove, > .driver = { > .name = "lp3943", > .of_match_table = of_match_ptr(lp3943_of_match), >