Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760471AbcDFASs (ORCPT ); Tue, 5 Apr 2016 20:18:48 -0400 Received: from mail-pa0-f65.google.com ([209.85.220.65]:34974 "EHLO mail-pa0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbcDFASq (ORCPT ); Tue, 5 Apr 2016 20:18:46 -0400 Date: Tue, 5 Apr 2016 16:18:41 -0800 From: Kent Overstreet To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Boaz Harrosh , Jan Kara , Keith Busch , Tejun Heo , Mike Snitzer Subject: Re: [PATCH 01/27] block: bio: introduce 4 helpers for cleanup Message-ID: <20160406001841.GA31161@kmo-pixel> References: <1459857443-20611-1-git-send-email-tom.leiming@gmail.com> <1459857443-20611-2-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459857443-20611-2-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 413 Lines: 9 On Tue, Apr 05, 2016 at 07:56:46PM +0800, Ming Lei wrote: > Some drivers access bio->bi_vcnt and bio->bi_io_vec directly, > firstly it isn't a good practice, secondly it may cause trouble > for converting to multipage bvecs. "not good practice" is OO bullshit snake oil without more justification. We don't plaster accessors everywhere without an actual reason. How would it cause trouble with multipage bvecs?