Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760853AbcDFAm3 (ORCPT ); Tue, 5 Apr 2016 20:42:29 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:51892 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670AbcDFAm1 (ORCPT ); Tue, 5 Apr 2016 20:42:27 -0400 Date: Tue, 5 Apr 2016 17:41:47 -0700 From: Shaohua Li To: Kent Overstreet CC: Jeff Moyer , Ming Lei , Jens Axboe , , , Christoph Hellwig , Eric Wheeler , Sebastian Roesner , "4.2+" Subject: Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Message-ID: <20160406004147.GA3100363@devbig084.prn1.facebook.com> References: <1459878246-9249-1-git-send-email-ming.lei@canonical.com> <20160405182720.GA2375685@devbig084.prn1.facebook.com> <20160406002733.GB31161@kmo-pixel> <20160406003006.GA3084175@devbig084.prn1.facebook.com> <20160406003604.GE31161@kmo-pixel> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160406003604.GE31161@kmo-pixel> User-Agent: Mutt/1.5.20 (2009-12-10) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-06_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 510 Lines: 11 On Tue, Apr 05, 2016 at 04:36:04PM -0800, Kent Overstreet wrote: > On Tue, Apr 05, 2016 at 05:30:07PM -0700, Shaohua Li wrote: > > this one: > > http://marc.info/?l=linux-kernel&m=145926976808760&w=2 > > Ah. that patch won't actually fix the bug, since md isn't using > blk_default_limits, it's using blk_set_stacking_limits(). Not really, the limit is set by under layer disk not md, otherwise it should be BLK_SAFE_MAX_SECTORS, but the reported bio has 2560 sectors. blk_set_stacking_limits() will use it.