Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759707AbcDFBV0 (ORCPT ); Tue, 5 Apr 2016 21:21:26 -0400 Received: from mail-bl2on0105.outbound.protection.outlook.com ([65.55.169.105]:58314 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759488AbcDFBVZ convert rfc822-to-8bit (ORCPT ); Tue, 5 Apr 2016 21:21:25 -0400 From: Hartley Sweeten To: Sudip Mukherjee , Ian Abbott , Greg Kroah-Hartman CC: "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" Subject: RE: [PATCH] staging: comedi: das1800: remove unused variable Thread-Topic: [PATCH] staging: comedi: das1800: remove unused variable Thread-Index: AQHRj0ayv1HPe+Sq10ymMrFhplG7AZ98JfPw Date: Wed, 6 Apr 2016 01:21:19 +0000 Message-ID: References: <1459866185-1722-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1459866185-1722-1-git-send-email-sudipm.mukherjee@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: 407d7754-74db-4771-00f6-08d35db9c253 x-microsoft-exchange-diagnostics: 1;BY1PR0101MB1063;5:Zd2HKlysotFGfzexYqAAtH5bcB4PhaE0gHjd+f09Tp3lTjOL/GOZoP+E7/UmWN7gCLu9WfWU9AiCl7byaQxZNkuGFkpydNzzW/TjEZwEPT/rssNNb3Tm317rvzniDnrKRZ2oYilZmLCnkmwLq3pzgg==;24:o85aUL7hSFz96UF6yZ3+VTsAbhflw336Ac44IkJl4c6moseaC766RVPNO51mK8rPE9VwYNm93BVLYuwYptq2uVA1vdtxXnA3acSzKXW1+Bw= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0101MB1063; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040046)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041046)(6043046)(6042046);SRVR:BY1PR0101MB1063;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0101MB1063; x-forefront-prvs: 0904004ECB x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(24454002)(33656002)(2950100001)(87936001)(77096005)(54356999)(76176999)(2900100001)(50986999)(106116001)(80792005)(164054004)(5001770100001)(92566002)(5008740100001)(122556002)(1220700001)(74316001)(19580395003)(19580405001)(3280700002)(5002640100001)(5004730100002)(102836003)(3846002)(6116002)(5003600100002)(586003)(4326007)(1096002)(2906002)(86362001)(3660700001)(66066001)(81166005)(189998001)(10400500002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0101MB1063;H:BY1PR0101MB1063.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2016 01:21:19.7111 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0101MB1063 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 558 Lines: 19 On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: > The variable unipolar was never used. > > Signed-off-by: Sudip Mukherjee > --- > > There may be a chance that reading from DAS1800_CONTROL_C is necessary > before reading from DAS1800_STATUS. If that is true then please discard > this patch. Actually the driver has a bug here. The analog input samples should be munged if the inputs are configured for bipolar mode. I have a series almost ready that cleans up this driver and fixes the bug. Thanks, Hartley