Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760070AbcDFCeT (ORCPT ); Tue, 5 Apr 2016 22:34:19 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:33330 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbcDFCeR (ORCPT ); Tue, 5 Apr 2016 22:34:17 -0400 Date: Tue, 5 Apr 2016 18:34:11 -0800 From: Kent Overstreet To: Ming Lei Cc: Jens Axboe , Linux Kernel Mailing List , linux-block@vger.kernel.org, Christoph Hellwig , Eric Wheeler , Sebastian Roesner , "4.2+" , Shaohua Li Subject: Re: [PATCH] block: make sure big bio is splitted into at most 256 bvecs Message-ID: <20160406023411.GA7793@kmo-pixel> References: <1459878246-9249-1-git-send-email-ming.lei@canonical.com> <20160406003025.GC31161@kmo-pixel> <20160406011028.GA32334@kmo-pixel> <20160406012839.GA32713@kmo-pixel> <20160406022249.GB7452@kmo-pixel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 401 Lines: 9 On Wed, Apr 06, 2016 at 10:30:22AM +0800, Ming Lei wrote: > Now limit.max_segments is for limiting segments from hw view, one this > segment may include lots of pages/bvecs. > > The current bio_clone() issue is that we can't clone from one bio which > includes more than 256 bvecs, maybe all these 256 bvecs belong to > one same hw segment. So the distinction is purely a post multipage bvec thing?