Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760717AbcDFDkl (ORCPT ); Tue, 5 Apr 2016 23:40:41 -0400 Received: from mail-bn1bon0072.outbound.protection.outlook.com ([157.56.111.72]:44197 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753272AbcDFDkj (ORCPT ); Tue, 5 Apr 2016 23:40:39 -0400 Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PART1 RFC v3 12/12] svm: Manage vcpu load/unload when enable AVIC To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <1458281388-14452-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1458281388-14452-13-git-send-email-Suravee.Suthikulpanit@amd.com> <20160318214450.GB2332@potion.brq.redhat.com> <56FCE556.80306@amd.com> <20160331141908.GA2171@potion.brq.redhat.com> <57038E6B.3080808@amd.com> <20160405145656.GA17400@potion.brq.redhat.com> CC: , , , , , , , , From: Suravee Suthikulpanit Message-ID: <57048521.80509@amd.com> Date: Wed, 6 Apr 2016 10:40:17 +0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160405145656.GA17400@potion.brq.redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [124.121.8.20] X-ClientProxiedBy: HKXPR03CA0093.apcprd03.prod.outlook.com (10.163.104.51) To BY1PR12MB0437.namprd12.prod.outlook.com (10.162.147.139) X-MS-Office365-Filtering-Correlation-Id: dd69a981-9efb-4184-ca3b-08d35dcd35ef X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;2:ljhwiyqV5mAZ1AFNv7pEGcxNnCgjS43IBiwFRluXC42JfXFo/73VINjIuU1uSChA2OWCC3V0SXTM72QE9zfq1S62OrTp1GFefI6+q74F4dgBHrqnrKgRUX8PJqT2mDZaTWvnoqoZwxAVXatGvp2MzEt6pX8ZkOkbx6JpTUQWmpVcOC/sf1BMIlbtX+ZpIRVV;3:xWwDhlnCmOHg5GnNcM7qKAGcX7pLCOsW7ARzoQfJfHTczE1iLcGkY8xaDEA9xjGYPoOTjl6rV0cEQHIo4Krs+6gs1ZwoLoxDdNN5Ao8w/Q7MuQahclTTwFbh0CQGNN+E;25:i4saMpc8yjSOv/abUp3IMkoYBQ4nIrAGT9RV8ycwRpNFmeB0CTLB5LbA9Ph9Fz3KJ6nIz60joUXbbqNiOyhqw/fsKI4NUmTLYHZ/fZqd8qHQECDhUf042BiriMGs1Fd/jTUQk3fC3LJHOvZkFKZSi5KyR81/e+mcHZcMEKX7ZHBXrukQ6jfGKeIVPNHpvaYTmajcrW3nLID0ECmnDlhuvro2tTwbpKcv5tV+oHEaBs8fVSwF1KyWpOcOFK2no2Ei+YkH9Pn9rk4PA8D1rNrRD0Dt1HpLLsfCA/QmRvML3jBnjHG9fVKyfH0b25EgmcEHMTnMQjF7ujr0htB637nBrQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;20:4pfCtB5wsmREaXpcKdeKAYuf4x9+UlJplQR8gYmVDW5M1XGPvKjuprzj4YNij7EI+2dVHudjYftFb7l9QRXr7MrRBma20WWPzCTblBB72PKA2oI39uaMrVki5mX3+znRoLfMADOEaqnimhourybZrwg1qBAI9LctKftGQXMfnEWXZFINBZ46dlmJKclfxk5n0Wwnw167ndoODW2Ozz3BsZDBRtEeF6+kN6C2hJmlMx/WuQh+ywbDK9lfhdTE1ykbZEtpMaAEsPjk9CrhRrirUeBXFR1b8yyA/MiO0celQV0Pndaca9HSqsXEQ0Po3TV+PeMPtDTSbHWbCIUkYRuC62IruAQGNcAppikPzaCE4As/iw4bENdbnwTQnbdUiG0wBqYlHJYrs4koYdDZuFRmouVcAnIgennLoo8azqR9W7Z2pstsqH2Fraye2GGcPBHPd0xmigCp/Ur3lNjDKtvUNHrFsJfP1ashKp4V93tch8lly37UNmsvfKDutTxNCWCb;4:8jCQujVqpFiaKtFchgSOBH8lj/jGt0e69XbHslOrX+sdMIvY9ysCxd4KxVxVHeU3wFONiYp8DRu/7J0+TE1Nm8w+dDFPaSOWUGsMOYVSjgbKrqvBp74621A4XR3Z7+CnhVG21gzmBC94Ibd7NOjjplDfwzISbprd0oYZACHoJ9/11HQrVb6AtMuJK64CP7qPrLkBplXnEGKmPG0DNJnK/CgYmjckX/X/PIbjOoW+rrDy2s25Bj6jcQQvsE9waJE6V2OA78Y919TSS/6NMNZwKyXca1Vt9oL2PfkRKWIi4ZUQWdPpIscIc8N+j40eauhIvmQOmQ2zO4Tfkaz5fWbfofZt0DMubl8DBayTO0WAniy5nK43EFdf5gIt0QMgUeRD X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:BY1PR12MB0437;BCL:0;PCL:0;RULEID:;SRVR:BY1PR12MB0437; X-Forefront-PRVS: 0904004ECB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(24454002)(2870700001)(65956001)(66066001)(117156001)(2950100001)(86362001)(81166005)(42186005)(189998001)(77096005)(92566002)(36756003)(122286003)(54356999)(4001350100001)(5008740100001)(50466002)(4326007)(93886004)(50986999)(76176999)(586003)(65816999)(65806001)(83506001)(117636001)(64126003)(2906002)(1096002)(110136002)(23676002)(6116002)(164054004)(47776003)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:BY1PR12MB0437;H:[192.168.0.19];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTFQUjEyTUIwNDM3OzIzOit2SUVRWnoremRQQXBWZkR3RmgrSFpuUHA2?= =?utf-8?B?T05mVDVEejlvZVJreWcwRHM2aEltYnQ1QkxiYXBQUlU0WFY0ckt1TzBVL0xC?= =?utf-8?B?aGdBSXZJVU5wSFJ0RFZORGJrOGM2QlZGTjFRUnBKcVp6aEl1ellPNU95YzJ1?= =?utf-8?B?SisweTJDRTAzRHM4VkJnQ2I5RGwxUGNRYjBWeUg2UGJ1Qk5xbmFCQmM0Vzd2?= =?utf-8?B?WTZvdzhNRHlZMGZXT2ZpQldpejZnTFlFLzRyZGt3Ykowa2dNazJLZGVIWi9m?= =?utf-8?B?OTM3RkFmampXa09yZWxSM1gwUU00TnkzamYwb0RlTTFJZlVINVYrM2VvaFdF?= =?utf-8?B?RVFKTGs1S0gvaXl3MUE4Rmhta2NGRGNSQ2I4SUxqcUFkNmVMZFJyRWNKUHQx?= =?utf-8?B?OGZ6bUU2WWgyK3lhUEtGVzZWVDBaTktaNXJUckllNyt5ZVhKVXFub1V5SkJJ?= =?utf-8?B?N3c1VG9OKzNVeUJFb24xNjFBRGJZVlRQNytNQmtpM0Z1dUJhcG5Jb3dDbXpz?= =?utf-8?B?ZzlldytSdzhsWlVVenFhVVp3OVZWUUVrZWZEVm13eVRScEJ4TjNpOE90alJD?= =?utf-8?B?VnZIQnZVMTNyblZCdlVDZnUvVE9xNU1GMU54bmFsY0M0VjMyczRIcFA1WWFL?= =?utf-8?B?anpXZUp6L01tRU92RmE5Y2p3RW9XQ0pqd0pXTWNjOWgyTUR1K1A0MU5TMG4w?= =?utf-8?B?VG9pWkRjS1RBWWhZNDNiL2xoM3RaSzFkREJDSmh3QWd0Q2c1RWxjOHFOQy9L?= =?utf-8?B?OE5vMWhNbiswMFR1RURqRmFrNStiN3VhRDR3WFMvalNyZ0t4NW1IQS9IUmky?= =?utf-8?B?NEpqamV1dlJqMG9ZMDhTS1hOMFM4Kzg2S0Rzc1QwUjlLM1B0T0dacUtjMGdi?= =?utf-8?B?RHUyZXFNNURYRkRTdzZvYkU2cjd2RWRzS3RXS1VPVGF4SVU0dzkzVWRoTDNU?= =?utf-8?B?UHRIYjZubW9Fb1F2RzhVa252dUhYYng4cEZFU1NiTUhuVkEyZU1rZlFaRUln?= =?utf-8?B?eGVyY1V3QjJGUU9RK010L2h1NmlSM1M3dGM5cTY0eS91TkgrWDJaakkrRHZR?= =?utf-8?B?ejI2c2oxNjN2UU40UTNjZ3cvZ3VRd3dZYkwrNFh1UEJtc3p5ZkNITzczV2p4?= =?utf-8?B?ZG5kUUlPSVhvQXdVWkMxbHZFUmZkUmo3OEhyZW04cnVlekkvTUdHaThBQ29r?= =?utf-8?B?WWhVVGNaY05DZytqODFtSmNWNDhjV0Ywekpod0xPYWlaMmlZS1JVTGVSdnVV?= =?utf-8?B?U1lCSlNUWUYvNlNIWDArT0dIVUpGeEo2N3V1cHgwallneW5WUWtTelhjdDA5?= =?utf-8?B?VVFVODA2UkV6QzZzTXQxS2xPbUlIK3JRU0wrbXhHWWtpOXUzblFGUEhhQVFy?= =?utf-8?B?dmtROHZYckFUdTFpRHpjbjhGQ0NkR1NocDlLSTd6TlVsSXdQVjZCNU5VM2cw?= =?utf-8?Q?sJT05A=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY1PR12MB0437;5:/LIQ/TGgjVeGNbAYng4hEgPlAoBA2CzeqGIG5SWe8zkIG0/tVK2ZdooELVaQN54QVhnhNyUPV2v/cQkMxztuI43ZDPl5IBZFrmub1K47G5r14pEjHOgJ5m7P3aYfXcQf1ETCC9tNyVZjM59SfdlkEg==;24:jcZMIHweoCzRNq4OUlPlMK1H+ohoKrA/dwmY+zu88on0f4As51Y7UpXKV1qtSr3eSO689t82Hvv6GRtAvFr9LL7IwQS1biB9vaPLS0DnLuQ=;20:XTlV/2KAuNLRrFXDWD+GDnQ19kQvWQh2XKsvmMA4NzH0I/NBpmN1TxkUiLXuYrdyaN5PyQKAVAcSsaXTU/37sZ7CeTqwEm32OEIID/EgUxoDgdMGO00XA+CNlgVjd7HxRblFN1BJcPzdbmWtzZvVRn5FbV+zRR5eQ9GU9HT3sheOSBKCRvEJ5R/p0SsFYov2if/fv606m6tOsRH1V9fPEkWUE339gckTBVuNoVzSNp+eVINhJ3HiNwWLzbIV933j X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2016 03:40:31.8019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR12MB0437 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 595 Lines: 22 Radim, On 04/05/2016 09:56 PM, Radim Krčmář wrote: > I meant to change the place where we remember that is_running must not > be true. Something like > > svm_vcpu_blocking(struct kvm_vcpu *vcpu): > vcpu->is_blocking = true; > avic_set_running(vcpu, false); > > avic_vcpu_load(struct kvm_vcpu *vcpu, bool is_load): > avic_set_running(vcpu, is_load && !vcpu->is_blocking) I assume that you also imply that we would also need: svm_vcpu_unblocking(struct kvm_vcpu *vcpu) { avic_set_running(vcpu, false); vcpu->is_blocking = false; } Thanks, Suravee