Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760919AbcDFFW4 (ORCPT ); Wed, 6 Apr 2016 01:22:56 -0400 Received: from mx2.suse.de ([195.135.220.15]:45685 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754167AbcDFFWz (ORCPT ); Wed, 6 Apr 2016 01:22:55 -0400 Date: Wed, 6 Apr 2016 07:22:52 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Rusty Russell cc: linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v2] module: fix noreturn attribute for __module_put_and_exit() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 739 Lines: 25 On Wed, 30 Mar 2016, Jiri Kosina wrote: > > __module_put_and_exit() is makred noreturn in module.h declaration, but is > > lacking the attribute in the definition, which makes some tools (such as > > sparse) unhappy. Amend the definition with the attribute as well (and > > reformat the declaration so that it uses more common format). > > > > Signed-off-by: Jiri Kosina > > --- > > > > v1 -> v2: use __noreturn instead of __attribute__((noreturn)) as requested > > by Rusty > > Rusty, friendly ping on this one. Not seeing this in your tree, let me send another friendly ping :) Rusty, if you want me to take this through trivial.git, just let me know, I'll happily do it. Thanks, -- Jiri Kosina SUSE Labs