Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753299AbcDFGFc (ORCPT ); Wed, 6 Apr 2016 02:05:32 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34834 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbcDFGF3 (ORCPT ); Wed, 6 Apr 2016 02:05:29 -0400 Date: Wed, 6 Apr 2016 01:05:27 -0500 From: Andy Gross To: Vinod Koul Cc: Stanimir Varbanov , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, Sinan Kaya , Pramod Gurav Subject: Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property Message-ID: <20160406060527.GC3873@hector.attlocal.net> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> <20160405234425.GD11586@vkoul-mobl.iind.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160405234425.GD11586@vkoul-mobl.iind.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 729 Lines: 17 On Tue, Apr 05, 2016 at 04:44:25PM -0700, Vinod Koul wrote: > On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote: > > Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++ > > drivers/dma/qcom/bam_dma.c | 7 +++++++ > > The binding should be a separate patch.. > > > > > + bdev->controlled_remotely = of_property_read_bool(pdev->dev.of_node, > > + "qcom,controlled-remotely"); > > + > > we need some defaults here, how will this work with boards withe older DT. By default the bam driver should assume that it can access the registers. It is only in specific cases where we have trustzone locking down these registers and assigning them to other remote processors.