Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752957AbcDFGck (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Apr 2016 02:32:40 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:37666 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751299AbcDFGci (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Apr 2016 02:32:38 -0400
Subject: Re: [PATCH v6 01/12] usb: hcd: Initialize hcd->flags to 0
To: Felipe Balbi <balbi@kernel.org>, <stern@rowland.harvard.edu>,
        <gregkh@linuxfoundation.org>, <peter.chen@freescale.com>
References: <1459865117-7032-1-git-send-email-rogerq@ti.com>
 <1459865117-7032-2-git-send-email-rogerq@ti.com> <87zit72rqz.fsf@intel.com>
CC: <dan.j.williams@intel.com>, <jun.li@freescale.com>,
        <mathias.nyman@linux.intel.com>, <tony@atomide.com>,
        <Joao.Pinto@synopsys.com>, <abrestic@chromium.org>,
        <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>
From: Roger Quadros <rogerq@ti.com>
Message-ID: <5704AD76.9080806@ti.com>
Date: Wed, 6 Apr 2016 09:32:22 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <87zit72rqz.fsf@intel.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 501
Lines: 22

On 06/04/16 09:09, Felipe Balbi wrote:
> 
> Hi,
> 
> Roger Quadros <rogerq@ti.com> writes:
>> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
>> index 2ca2cef..6b1930d 100644
>> --- a/drivers/usb/core/hcd.c
>> +++ b/drivers/usb/core/hcd.c
>> @@ -2706,6 +2706,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
>>  	int retval;
>>  	struct usb_device *rhdev;
>>  
>> +	hcd->flags = 0;
> 
> seems like this would make more sense in usb_del_hcd() instead.
> 

OK, I'll move it there.

cheers,
-roger