Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932483AbcDFIOr (ORCPT ); Wed, 6 Apr 2016 04:14:47 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:34603 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753843AbcDFIOi (ORCPT ); Wed, 6 Apr 2016 04:14:38 -0400 MIME-Version: 1.0 In-Reply-To: References: <1459480051-3701-1-git-send-email-yangbo.lu@nxp.com> Date: Wed, 6 Apr 2016 10:14:36 +0200 Message-ID: Subject: Re: [v7, 0/5] Fix eSDHC host version register bug From: Ulf Hansson To: Yangbo Lu , Scott Wood Cc: "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-clk@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "netdev@vger.kernel.org" , linux-mmc , Rob Herring , Russell King , Jochen Friedrich , Joerg Roedel , Claudiu Manoil , Bhupesh Sharma , Zhao Qiang , Kumar Gala , Santosh Shilimkar , Yang-Leo Li , Xiaobo Xie Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 37 >> >> I was about to queue this for next, when I noticed that checkpatch is >> complaining/warning lots about these patches. Can you please a round of >> checkpatch and fix what makes sense. >> >> Kind regards >> Uffe > > [Lu Yangbo-B47093] Sorry about this, Uffe... No worries! > Should I ignore the warnings that update MAINTAINERS? drivers/soc/fsl/guts.c isn't part of the MAINTAINERS file, it should be. I also realize that the FREESCALE QUICC ENGINE LIBRARY section drivers/soc/fsl/qe/* also need an active maintainer, as it's currently orphan. Perhaps we should have create a new section for drivers/soc/fsl/* instead that covers all of the above? Maybe you or Scott are interested to pick it up? I also noted that, "include/linux/fsl/" isn't present in MAINTAINERS, please add that as well. > Regarding the 'undocumented' warning, I will added a patch updates doc before all the patches, Ok? Yes, good! > > Thanks a lot :) > Kind regards Uffe