Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933556AbcDFIRr (ORCPT ); Wed, 6 Apr 2016 04:17:47 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36826 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754272AbcDFIRp (ORCPT ); Wed, 6 Apr 2016 04:17:45 -0400 Subject: Re: [PATCH 1/4] KVM: MMU: fix permission_fault() To: Xiao Guangrong References: <1458911978-19430-1-git-send-email-guangrong.xiao@linux.intel.com> <56F54983.4010508@redhat.com> <56FABECE.40601@linux.intel.com> <56FAE0F3.9090809@redhat.com> <56FB3254.5070403@linux.intel.com> <56FB73E0.7060601@redhat.com> <56FB7489.2080304@linux.intel.com> <57048231.6070103@linux.intel.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, "Han, Huaitong" From: Paolo Bonzini Message-ID: <5704C623.2060300@redhat.com> Date: Wed, 6 Apr 2016 10:17:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <57048231.6070103@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 503 Lines: 20 On 06/04/2016 05:27, Xiao Guangrong wrote: > > I tested it and it is failed: > > test pte.p pte.user pde.p pde.user pde.a pde.pse pkru.wd pkey=1 user > write efer.nx cr4.pke: FAIL: error code 27 expected 7 > Dump mapping: address: 0x123400000000 > ------L4: 2ebe007 > ------L3: 2ebf007 > ------L2: 8000000020000a5 > > So PFEC.PKEY is set even if the ordinary check failed (caused by pde.rw > = 0), the kvm code is > right. :) Cool, thanks very much. I'll fix both QEMU and kvm-unit-tests. Paolo