Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933712AbcDFInL (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Apr 2016 04:43:11 -0400
Received: from mx2.suse.de ([195.135.220.15]:58564 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932215AbcDFInJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Apr 2016 04:43:09 -0400
Date: Wed, 6 Apr 2016 10:43:06 +0200 (CEST)
From: Miroslav Benes <mbenes@suse.cz>
To: Jessica Yu <jeyu@redhat.com>
cc: Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        Chris J Arges <chris.j.arges@canonical.com>,
        eugene.shatokhin@rosalab.ru, live-patching@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        pmladek@suse.cz
Subject: Re: Bug with paravirt ops and livepatches
In-Reply-To: <alpine.LNX.2.00.1604061014520.27016@pobox.suse.cz>
Message-ID: <alpine.LNX.2.00.1604061038120.27016@pobox.suse.cz>
References: <20160329120518.GA21252@canonical.com> <alpine.LNX.2.00.1603291450090.26309@pobox.suse.cz> <alpine.LNX.2.00.1603291504010.3656@cbobk.fhfr.pm> <alpine.LNX.2.00.1604011546110.16158@cbobk.fhfr.pm> <alpine.LNX.2.00.1604011745370.27264@pobox.suse.cz>
 <20160401190704.GB7837@canonical.com> <alpine.LNX.2.00.1604012132430.16158@cbobk.fhfr.pm> <20160404161428.3qap2i4vpgda66iw@treble.redhat.com> <alpine.LNX.2.00.1604051445530.1180@pobox.suse.cz> <20160405191907.GC10567@packer-debian-8-amd64.digitalocean.com>
 <alpine.LNX.2.00.1604061014520.27016@pobox.suse.cz>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 739
Lines: 19

On Wed, 6 Apr 2016, Miroslav Benes wrote:

> Anyway I see there are some new comments on github. I'll look at those. 
> But I'd prefer to discuss all the relevant things (that is kpatch 
> unspecific) here. It would make it easier.

And you do (after seeing dates of the posts there), sorry for the noise.

Jessica, I think I am perfectly fine with introducing some arch-specific 
code because of this problem.

We used generic apply_relocate_add() because it was a single 
arch-independent entry point. There is no such things for paravirt_ops, 
alternatives, jump labels and such things. In fact only module_finalize() 
is there and that is not enough. So some arch-specific code in livepatch 
seems to be unnecessary.

Cheers,
Miroslav