Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933887AbcDFJJJ (ORCPT ); Wed, 6 Apr 2016 05:09:09 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:35120 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933856AbcDFJJE (ORCPT ); Wed, 6 Apr 2016 05:09:04 -0400 Subject: Re: [PATCH] arm64/sunxi: 4.6-rc1: Add dependency on generic irq chip To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, arm@kernel.org References: <1459245786-11905-1-git-send-email-suzuki.poulose@arm.com> Cc: olof@lixom.net, arnd@arndb.de, linux-kernel@vger.kernel.org From: Andre Przywara Organization: ARM Ltd. Message-ID: <5704D13E.6060701@arm.com> Date: Wed, 6 Apr 2016 10:05:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1459245786-11905-1-git-send-email-suzuki.poulose@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2444 Lines: 62 Hi, On 29/03/16 11:03, Suzuki K Poulose wrote: > Commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option"), > added support for ARCH_SUNXI on arm64, but failed to select > GENERIC_IRQ_CHIP, which is required for drivers/irqchip/irq-sunxi-nmi.c > and causes build failures like : Thanks for the catch! GENERIC_IRQ_CHIP somehow gets selected by defconfig, so I didn't see the issue. Currently we don't need the irq-sunxi-nmi driver, but we may in the future and it depends on CONFIG_ARCH_SUNXI only, so I guess this patch is the easiest solution (rather than creating a separate config symbol for it, which may be an option for later). So... > > UPD include/generated/compile.h > CC init/version.o > LD init/built-in.o > drivers/built-in.o: In function `sunxi_sc_nmi_set_type': > drivers/irqchip/irq-sunxi-nmi.c:114: undefined reference to `irq_setup_alt_chip' > drivers/built-in.o: In function `irq_domain_add_linear': > include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops' > include/linux/irqdomain.h:253: undefined reference to `irq_generic_chip_ops' > drivers/built-in.o: In function `sunxi_sc_nmi_irq_init': > drivers/irqchip/irq-sunxi-nmi.c:146: undefined reference to `irq_alloc_domain_generic_chips' > drivers/irqchip/irq-sunxi-nmi.c:161: undefined reference to `irq_get_domain_generic_chip' > drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit' > drivers/irqchip/irq-sunxi-nmi.c:171: undefined reference to `irq_gc_mask_set_bit' > drivers/irqchip/irq-sunxi-nmi.c:172: undefined reference to `irq_gc_ack_set_bit' > drivers/irqchip/irq-sunxi-nmi.c:170: undefined reference to `irq_gc_mask_clr_bit' > > Fixes: commit ce3dd55b99b1 ("arm64: Introduce Allwinner SoC config option") > Cc: Andre Przywara > Signed-off-by: Suzuki K Poulose Acked-by: Andre Przywara Cheers, Andre. > --- > arch/arm64/Kconfig.platforms | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index efa77c1..521b1ec 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -2,6 +2,7 @@ menu "Platform selection" > > config ARCH_SUNXI > bool "Allwinner sunxi 64-bit SoC Family" > + select GENERIC_IRQ_CHIP > help > This enables support for Allwinner sunxi based SoCs like the A64. > >