Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933921AbcDFJJn (ORCPT ); Wed, 6 Apr 2016 05:09:43 -0400 Received: from mx2.suse.de ([195.135.220.15]:60422 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932305AbcDFJJk (ORCPT ); Wed, 6 Apr 2016 05:09:40 -0400 Date: Wed, 6 Apr 2016 11:09:37 +0200 (CEST) From: Miroslav Benes To: Jessica Yu cc: Josh Poimboeuf , Jiri Kosina , Chris J Arges , eugene.shatokhin@rosalab.ru, live-patching@vger.kernel.org, Linux Kernel Mailing List , pmladek@suse.cz Subject: Re: Bug with paravirt ops and livepatches In-Reply-To: Message-ID: References: <20160329120518.GA21252@canonical.com> <20160401190704.GB7837@canonical.com> <20160404161428.3qap2i4vpgda66iw@treble.redhat.com> <20160405191907.GC10567@packer-debian-8-amd64.digitalocean.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 822 Lines: 20 On Wed, 6 Apr 2016, Miroslav Benes wrote: > On Wed, 6 Apr 2016, Miroslav Benes wrote: > > > Anyway I see there are some new comments on github. I'll look at those. > > But I'd prefer to discuss all the relevant things (that is kpatch > > unspecific) here. It would make it easier. > > And you do (after seeing dates of the posts there), sorry for the noise. > > Jessica, I think I am perfectly fine with introducing some arch-specific > code because of this problem. > > We used generic apply_relocate_add() because it was a single > arch-independent entry point. There is no such things for paravirt_ops, > alternatives, jump labels and such things. In fact only module_finalize() > is there and that is not enough. So some arch-specific code in livepatch > seems to be unnecessary. s/unnecessary/necessary/