Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934009AbcDFJan (ORCPT ); Wed, 6 Apr 2016 05:30:43 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:60872 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932159AbcDFJam (ORCPT ); Wed, 6 Apr 2016 05:30:42 -0400 Date: Wed, 6 Apr 2016 11:30:36 +0200 From: Peter Zijlstra To: xlpang@redhat.com Cc: linux-kernel@vger.kernel.org, Juri Lelli , Ingo Molnar , Steven Rostedt Subject: Re: [PATCH] sched/deadline: No need to check NULL later_mask Message-ID: <20160406093036.GQ3448@twins.programming.kicks-ass.net> References: <1459509198-26543-1-git-send-email-xlpang@redhat.com> <20160401112919.GP3430@twins.programming.kicks-ass.net> <56FE66A5.9050004@redhat.com> <20160401162136.GM3448@twins.programming.kicks-ass.net> <56FF9B84.2030307@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56FF9B84.2030307@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 644 Lines: 16 On Sat, Apr 02, 2016 at 06:14:28PM +0800, Xunlei Pang wrote: > Your proposal is very nice! > > At the sched_init() stage we only have one (to be "idle") task and with irq disabled, > no scheduling will happen, and the cpu_possible_mask was already initiated, so it's > safe to simply move them there. > > Also, how about rt&deadline sharing a percpu mask? Because only one of them can > use the mask at a moment, operations are always under some spin_lock_irqsave(). > > I made a new patch below, slightly tested by running tens of rt&dl tasks for a while, > are you fine with it? Yep, looks fine. Please submit as a proper patch. Thanks!