Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755295AbcDFKNi (ORCPT ); Wed, 6 Apr 2016 06:13:38 -0400 Received: from m50-133.163.com ([123.125.50.133]:41322 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754433AbcDFKNg (ORCPT ); Wed, 6 Apr 2016 06:13:36 -0400 From: zengzhaoxiu@163.com To: iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, davem@davemloft.net, jiri@resnulli.us Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiu Zeng Subject: [PATCH v2 24/30] ethernet: use parity8 in sun/niu.c Date: Wed, 6 Apr 2016 18:11:40 +0800 Message-Id: <1459937500-8246-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <57031D9D.801@gmail.com> References: <57031D9D.801@gmail.com> X-CM-TRANSID: DdGowADnXpPd4ARX0c2UAQ--.15958S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr4DZr43AF48Zw1fuw4xXrb_yoWDGrcEka 4jqF1fuF4UK3yYkr4qkr47A34Y9w1kZr4fua40yrW3ZFnrur15tr1kuFy3Jrs5Ww1xGF9r XrsrXayfJ3yIvjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU09iSJUUUUU== X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/1tbiGQFDgFXlSB8UWgAAsy Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 35 From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/net/ethernet/sun/niu.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index 9cc4564..8c344ef 100644 --- a/drivers/net/ethernet/sun/niu.c +++ b/drivers/net/ethernet/sun/niu.c @@ -2742,18 +2742,12 @@ static int niu_set_alt_mac_rdc_table(struct niu *np, int idx, static u64 vlan_entry_set_parity(u64 reg_val) { - u64 port01_mask; - u64 port23_mask; - - port01_mask = 0x00ff; - port23_mask = 0xff00; - - if (hweight64(reg_val & port01_mask) & 1) + if (parity8(reg_val)) reg_val |= ENET_VLAN_TBL_PARITY0; else reg_val &= ~ENET_VLAN_TBL_PARITY0; - if (hweight64(reg_val & port23_mask) & 1) + if (parity8((unsigned int)reg_val >> 8)) reg_val |= ENET_VLAN_TBL_PARITY1; else reg_val &= ~ENET_VLAN_TBL_PARITY1; -- 2.5.0