Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbcDFKVd (ORCPT ); Wed, 6 Apr 2016 06:21:33 -0400 Received: from m50-133.163.com ([123.125.50.133]:38736 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbcDFKVa (ORCPT ); Wed, 6 Apr 2016 06:21:30 -0400 From: zengzhaoxiu@163.com To: dmitry.torokhov@gmail.com, benjamin.tissoires@redhat.com, ulrik.debie-os@e2big.org, hdegoede@redhat.com, peter.hutterer@who-t.net, tiwai@suse.de, dusonlin@emc.com.tw Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoxiu Zeng Subject: [PATCH v2 29/30] input: use parity8 in elantech Date: Wed, 6 Apr 2016 18:20:14 +0800 Message-Id: <1459938014-8603-1-git-send-email-zengzhaoxiu@163.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <57031D9D.801@gmail.com> References: <57031D9D.801@gmail.com> X-CM-TRANSID: DdGowADH_pLg4gRXeSKVAQ--.51696S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ArWrGF15uFy5Gr18Aw4ruFg_yoW8Ww4fpF W5XryUKrWkta13t34DtF4DAFyrtwn2gas8KFWkW3sYqr4UJFWSvr15JrW29FyqyFy5CF4j van0yr45GFs2ka7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jakskUUUUU= X-Originating-IP: [112.95.225.98] X-CM-SenderInfo: p2hqw6xkdr5xrx6rljoofrz/1tbiowdDgFUL5eQoZAABs1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 53 From: Zhaoxiu Zeng Remove even parity table, use parity8 instead. Signed-off-by: Zhaoxiu Zeng --- drivers/input/mouse/elantech.c | 10 +++------- drivers/input/mouse/elantech.h | 1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c index 78f93cf..bbb4aa6 100644 --- a/drivers/input/mouse/elantech.c +++ b/drivers/input/mouse/elantech.c @@ -693,9 +693,9 @@ static int elantech_packet_check_v1(struct psmouse *psmouse) p3 = (packet[0] & 0x04) >> 2; - return etd->parity[packet[1]] == p1 && - etd->parity[packet[2]] == p2 && - etd->parity[packet[3]] == p3; + return parity8(packet[1]) != p1 && + parity8(packet[2]) != p2 && + parity8(packet[3]) != p3; } static int elantech_debounce_check_v2(struct psmouse *psmouse) @@ -1635,10 +1635,6 @@ int elantech_init(struct psmouse *psmouse) psmouse_reset(psmouse); - etd->parity[0] = 1; - for (i = 1; i < 256; i++) - etd->parity[i] = etd->parity[i & (i - 1)] ^ 1; - /* * Do the version query again so we can store the result */ diff --git a/drivers/input/mouse/elantech.h b/drivers/input/mouse/elantech.h index e1cbf40..542c5d9 100644 --- a/drivers/input/mouse/elantech.h +++ b/drivers/input/mouse/elantech.h @@ -141,7 +141,6 @@ struct elantech_data { unsigned int y_max; unsigned int width; struct finger_pos mt[ETP_MAX_FINGERS]; - unsigned char parity[256]; int (*send_cmd)(struct psmouse *psmouse, unsigned char c, unsigned char *param); void (*original_set_rate)(struct psmouse *psmouse, unsigned int rate); }; -- 2.5.0