Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbcDFKlD (ORCPT ); Wed, 6 Apr 2016 06:41:03 -0400 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:51670 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbcDFKlA (ORCPT ); Wed, 6 Apr 2016 06:41:00 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] staging: comedi: das1800: remove unused variable To: Hartley Sweeten , Sudip Mukherjee , Greg Kroah-Hartman References: <1459866185-1722-1-git-send-email-sudipm.mukherjee@gmail.com> <5704D9AD.4050807@mev.co.uk> Cc: "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" From: Ian Abbott Message-ID: <5704E7B8.6000707@mev.co.uk> Date: Wed, 6 Apr 2016 11:40:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <5704D9AD.4050807@mev.co.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1344 Lines: 36 On 06/04/16 10:41, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukherjee >>> --- >>> >>> There may be a chance that reading from DAS1800_CONTROL_C is necessary >>> before reading from DAS1800_STATUS. If that is true then please discard >>> this patch. >> >> Actually the driver has a bug here. >> >> The analog input samples should be munged if the inputs are >> configured for >> bipolar mode. >> >> I have a series almost ready that cleans up this driver and fixes the >> bug. > > Hi Hartley, can the bug fix be placed at the top of your patch series? > Thanks. > The bug has been there forever (even in the "out-of-tree" version from comedi.org, where I have just fixed it). There have been patches applied to reformat and remove the incorrect bits of code, including a142785d7c9d ("Staging: comedi: das1800: fixed multiple brace coding style issues and pointer declaration style errors") and 82d28561b7e0 ("staging: comedi: Remove if condition."). The latter patch, 82d28561b7e0, mainly served to hide the bug further! -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-