MIME-Version: 1.0
In-Reply-To: <20160406024027.GX1990@wotan.suse.de>
References: <20160406024027.GX1990@wotan.suse.de>
Date: Wed, 6 Apr 2016 12:07:36 +0100
Message-ID: <CAFLBxZbRjB6QWH5GbG6osCXat9NQVUAyDYrAMrdALbCofpX3Dg@mail.gmail.com>
Subject: Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry
From: George Dunlap <george.dunlap@citrix.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
CC: Andrew Cooper <andrew.cooper3@citrix.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        David Vrabel <david.vrabel@citrix.com>,
        =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <roger.pau@citrix.com>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Juergen Gross <jgross@suse.com>, Charles Arndol <carnold@suse.com>,
        Jim Fehlig <jfehlig@suse.com>, Jan Beulich <JBeulich@suse.com>,
        Daniel Kiper <daniel.kiper@oracle.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        the arch/x86 maintainers <x86@kernel.org>,
        "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Michael Chang <MChang@suse.com>,
        "Andy Lutomirski" <luto@amacapital.net>, joeyli <jlee@suse.com>,
        Julien Grall <julien.grall@arm.com>,
        =?UTF-8?B?Vm9qdMSbY2ggUGF2bMOtaw==?= <vojtech@suse.cz>,
        Borislav Petkov <bp@alien8.de>,
        xen-devel <xen-devel@lists.xenproject.org>, Gary Lin <GLin@suse.com>,
        Jeffrey Cheung <JCheung@suse.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2361
Lines: 58

On Wed, Apr 6, 2016 at 3:40 AM, Luis R. Rodriguez <mcgrof@kernel.org> wrote:
> A huge summary of the discussion over EFI boot option for HVMLite is now on a
> wiki [2], below I'll just provide the outline of the discussion. Consider this a
> request for more public review, feel free to take any of the items below and
> elaborate on it as you see fit.
[snip]
>   * Issues with boot x86 boot entries
>     * Small x86 zero page stubs
[snip]
>   * Points against using EFI
>     * Nulling the claimed boot loader effect

I'm a bit confused about this. You list exactly two arguments against
the proposed stub in the "con" section:
1. Bootloaders may not be able to use the extra entry point
2. It's an extra entry point

And then later, in another section, you actually list the reason #1 is
irrelevant: bootloaders don't matter because the stub is there to boot
from the Xen hypervisor.

So the only actual argument you have against the proposed PVH stub in
the linked document is that it's an extra entry point.

>   * Why use EFI for HVMlite
>     * EFI calling conventions are standardized
>     * EFI entry generalizes what new HVMLite entry proposes
>     * Further semantics may be needed
>     * Match Xen ARM's clean solution
>     * You don't need full EFI emulation
>       * Minimal EFI stubs for guests
>         * GetMemoryMap()
>         * ExitBootServices()
>       * EFI stubs which may be needed for guests
>         * Exit()
>         * Variable operation functions
>       * EFI stubs not needed for guests
>         * GetTime()/SetTime()
>         * SetVirtualAddressMap()
>         * ResetSystem()
>       * dom0 EFI
>       * domU EFI emulation possibilities
>         * Xen implements its own EFI environment for guests
>         * Xen uses Tianocore / OVMF

So rather than make a new entry point which does just the minimal
amount of work to run on a software interface (Xen), you want to take
an interface designed for hardware (EFI) and put in hacks so that it
knows that sometimes some EFI services are not available?  That sounds
like it's going to make the EFI path just as unmanageable as the
current PV path.

Using the EFI entry point would certainly make sense if it was
actually simpler than the proposed extra entry point.  But it sounds
like it's going to be more complicated, not only for Xen, but also for
Linux.

 -George