From: "Du, Changbin" <changbin.du@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "balbi@kernel.org" <balbi@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue
 available space
Thread-Topic: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue
 available space
Thread-Index: AQHRj9/MHbvGmuZkhkCc7c4d4XOF9Z98JpGAgACp8lA=
Date: Wed, 6 Apr 2016 11:38:22 +0000
Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A05CE2D57@SHSMSX103.ccr.corp.intel.com>
References: <1459931243-26405-1-git-send-email-changbin.du@intel.com>
 <20160406092509.GA29930@kroah.com>
In-Reply-To: <20160406092509.GA29930@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1135
Lines: 38

> > This can be used to check some special issues, like whether data is
> > successfully copied from memory to fifo when a trb is blocked.
> >
> > Signed-off-by: Du, Changbin <changbin.du@intel.com>
> > ---
> >  drivers/usb/dwc3/core.h    |  5 +++++
> >  drivers/usb/dwc3/debugfs.c | 45
> +++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 50 insertions(+)
> 
> Why did you not include the linux-usb@vger mailing list?
> 
Just forget it :)

> >  static int dwc3_testmode_show(struct seq_file *s, void *unused)
> >  {
> >  	struct dwc3		*dwc = s->private;
> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc)
> >  		goto err1;
> >  	}
> >
> > +	file = debugfs_create_file("fifo", S_IRUGO, root, dwc,
> &dwc3_fifo_fops);
> > +	if (!file) {
> > +		ret = -ENOMEM;
> 
> Um, no, that's not the error here.  You shouldn't care at all about
> debugfs api call results.  Just keep moving on here please.
> 
> thanks,
> 
> greg k-h

Agree with you. I will create another patch to cleanup this piece of code. 
And I found a memory leak issue there, dwc->regset never released. Will also fix it.

Thanks,
Du, Changbin