Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932704AbcDFMBx (ORCPT ); Wed, 6 Apr 2016 08:01:53 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:12861 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754079AbcDFMBv (ORCPT ); Wed, 6 Apr 2016 08:01:51 -0400 Date: Wed, 6 Apr 2016 19:57:32 +0800 From: Jisheng Zhang To: Baolin Wang CC: , , , , , , , , , , Subject: Re: [PATCH] mmc: Remove some redundant debug prints Message-ID: <20160406195732.67430c96@xhacker> In-Reply-To: <5cddc2f870eccf8cf50d463c72d2908dad9e1017.1459942344.git.baolin.wang@linaro.org> References: <5cddc2f870eccf8cf50d463c72d2908dad9e1017.1459942344.git.baolin.wang@linaro.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-06_06:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1604060176 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2783 Lines: 89 On Wed, 6 Apr 2016 19:38:30 +0800 Baolin Wang wrote: > This patch removes some redundant debug prints, since we have added some > tracepoints to help with performance analysis of MMC subsystem. I think the debug prints you removed are useful for debugging mmc err, how is this purpose achieved by tracepoints? From another side, why should I enable tracepoints to debug mmc err? Thanks > > Signed-off-by: Baolin Wang > --- > drivers/mmc/core/core.c | 52 ----------------------------------------------- > 1 file changed, 52 deletions(-) > > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c > index f80b3ab..3f1362a 100644 > --- a/drivers/mmc/core/core.c > +++ b/drivers/mmc/core/core.c > @@ -157,33 +157,6 @@ void mmc_request_done(struct mmc_host *host, struct mmc_request *mrq) > > led_trigger_event(host->led, LED_OFF); > > - if (mrq->sbc) { > - pr_debug("%s: req done : %d: %08x %08x %08x %08x\n", > - mmc_hostname(host), mrq->sbc->opcode, > - mrq->sbc->error, > - mrq->sbc->resp[0], mrq->sbc->resp[1], > - mrq->sbc->resp[2], mrq->sbc->resp[3]); > - } > - > - pr_debug("%s: req done (CMD%u): %d: %08x %08x %08x %08x\n", > - mmc_hostname(host), cmd->opcode, err, > - cmd->resp[0], cmd->resp[1], > - cmd->resp[2], cmd->resp[3]); > - > - if (mrq->data) { > - pr_debug("%s: %d bytes transferred: %d\n", > - mmc_hostname(host), > - mrq->data->bytes_xfered, mrq->data->error); > - } > - > - if (mrq->stop) { > - pr_debug("%s: (CMD%u): %d: %08x %08x %08x %08x\n", > - mmc_hostname(host), mrq->stop->opcode, > - mrq->stop->error, > - mrq->stop->resp[0], mrq->stop->resp[1], > - mrq->stop->resp[2], mrq->stop->resp[3]); > - } > - > if (mrq->done) > mrq->done(mrq); > } > @@ -236,31 +209,6 @@ static int mmc_start_request(struct mmc_host *host, struct mmc_request *mrq) > if (mmc_card_removed(host->card)) > return -ENOMEDIUM; > > - if (mrq->sbc) { > - pr_debug("<%s: starting CMD%u arg %08x flags %08x>\n", > - mmc_hostname(host), mrq->sbc->opcode, > - mrq->sbc->arg, mrq->sbc->flags); > - } > - > - pr_debug("%s: starting CMD%u arg %08x flags %08x\n", > - mmc_hostname(host), mrq->cmd->opcode, > - mrq->cmd->arg, mrq->cmd->flags); > - > - if (mrq->data) { > - pr_debug("%s: blksz %d blocks %d flags %08x " > - "tsac %d ms nsac %d\n", > - mmc_hostname(host), mrq->data->blksz, > - mrq->data->blocks, mrq->data->flags, > - mrq->data->timeout_ns / 1000000, > - mrq->data->timeout_clks); > - } > - > - if (mrq->stop) { > - pr_debug("%s: CMD%u arg %08x flags %08x\n", > - mmc_hostname(host), mrq->stop->opcode, > - mrq->stop->arg, mrq->stop->flags); > - } > - > WARN_ON(!host->claimed); > > mrq->cmd->error = 0;