Date: Wed, 6 Apr 2016 14:09:01 +0200 (CEST)
From: Miroslav Benes <mbenes@suse.cz>
To: Chris J Arges <chris.j.arges@canonical.com>
cc: Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        jeyu@redhat.com, eugene.shatokhin@rosalab.ru,
        live-patching@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        pmladek@suse.cz
Subject: Re: Bug with paravirt ops and livepatches
In-Reply-To: <20160406103821.GA4968@canonical.com>
Message-ID: <alpine.LNX.2.00.1604061406080.30748@pobox.suse.cz>
References: <alpine.LNX.2.00.1603291450090.26309@pobox.suse.cz> <alpine.LNX.2.00.1603291504010.3656@cbobk.fhfr.pm> <alpine.LNX.2.00.1604011546110.16158@cbobk.fhfr.pm> <alpine.LNX.2.00.1604011745370.27264@pobox.suse.cz> <20160401190704.GB7837@canonical.com>
 <alpine.LNX.2.00.1604012132430.16158@cbobk.fhfr.pm> <20160404161428.3qap2i4vpgda66iw@treble.redhat.com> <alpine.LNX.2.00.1604051445530.1180@pobox.suse.cz> <20160405232729.GA18198@canonical.com> <alpine.LNX.2.00.1604061103390.27016@pobox.suse.cz>
 <20160406103821.GA4968@canonical.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 423
Lines: 15

On Wed, 6 Apr 2016, Chris J Arges wrote:

> I think this approach needs more thought and my code has bug(s).

And indeed there is...

long (*__kvm_arch_vm_ioctl)(struct file *filp, unsigned long ioctl, unsigned long arg) = NULL;

Use a different name than __kvm_arch_vm_ioctl and (ideally) make it 
static.

kallsyms_lookup_name("__kvm_arch_vm_ioctl") returns the address of this 
variable from the patch module.

Miroslav