Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755145AbcDFM1S (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Apr 2016 08:27:18 -0400
Received: from mga09.intel.com ([134.134.136.24]:47396 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755075AbcDFM1Q (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Apr 2016 08:27:16 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; 
   d="asc'?scan'208";a="80110849"
From: Felipe Balbi <balbi@kernel.org>
To: Jun Li <jun.li@nxp.com>, Baolin Wang <baolin.wang@linaro.org>,
        Peter Chen <hzpeterchen@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Peter Chen <peter.chen@freescale.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        "r.baldyga\@samsung.com" <r.baldyga@samsung.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
        Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
        "patches\@opensource.wolfsonmicro.com" 
	<patches@opensource.wolfsonmicro.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        USB <linux-usb@vger.kernel.org>,
        "device-mainlining\@lists.linuxfoundation.org" 
	<device-mainlining@lists.linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v9 2/4] gadget: Support for the usb charger framework
In-Reply-To: <AM4PR04MB2130F58AA1018FFD367C89E0899F0@AM4PR04MB2130.eurprd04.prod.outlook.com>
References: <cover.1459494743.git.baolin.wang@linaro.org> <13c2f4fb71958bf9a5527acbed8b8b60dc569656.1459494744.git.baolin.wang@linaro.org> <20160406071956.GA21101@shlinux2.ap.freescale.net> <CAMz4kuJkf0Q1JKdc5W8EcDBvr6MccTcdZa-Pse_Z4pFwySTSDA@mail.gmail.com> <AM4PR04MB2130F58AA1018FFD367C89E0899F0@AM4PR04MB2130.eurprd04.prod.outlook.com>
User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu)
Date: Wed, 06 Apr 2016 15:21:41 +0300
Message-ID: <871t6j2ai2.fsf@intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 3190
Lines: 82

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Jun Li <jun.li@nxp.com> writes:
>> -----Original Message-----
>> From: linux-usb-owner@vger.kernel.org [mailto:linux-usb-
>> owner@vger.kernel.org] On Behalf Of Baolin Wang
>> Sent: Wednesday, April 06, 2016 6:47 PM
>> To: Peter Chen <hzpeterchen@gmail.com>
>> Cc: Felipe Balbi <balbi@kernel.org>; Greg KH <gregkh@linuxfoundation.org=
>;
>> Sebastian Reichel <sre@kernel.org>; Dmitry Eremin-Solenikov
>> <dbaryshkov@gmail.com>; David Woodhouse <dwmw2@infradead.org>; Peter Chen
>> <peter.chen@freescale.com>; Alan Stern <stern@rowland.harvard.edu>;
>> r.baldyga@samsung.com; Yoshihiro Shimoda
>> <yoshihiro.shimoda.uh@renesas.com>; Lee Jones <lee.jones@linaro.org>; Ma=
rk
>> Brown <broonie@kernel.org>; Charles Keepax
>> <ckeepax@opensource.wolfsonmicro.com>; patches@opensource.wolfsonmicro.c=
om;
>> Linux PM list <linux-pm@vger.kernel.org>; USB <linux-usb@vger.kernel.org=
>;
>> device-mainlining@lists.linuxfoundation.org; LKML <linux-
>> kernel@vger.kernel.org>
>> Subject: Re: [PATCH v9 2/4] gadget: Support for the usb charger framework
>>=20
>> On 6 April 2016 at 15:19, Peter Chen <hzpeterchen@gmail.com> wrote:
>> > On Fri, Apr 01, 2016 at 03:21:50PM +0800, Baolin Wang wrote:
>> >>
>> >> @@ -563,6 +564,8 @@ struct usb_gadget_ops {
>> >>       struct usb_ep *(*match_ep)(struct usb_gadget *,
>> >>                       struct usb_endpoint_descriptor *,
>> >>                       struct usb_ss_ep_comp_descriptor *);
>> >> +     /* get the charger type */
>> >> +     enum usb_charger_type (*get_charger_type)(struct usb_gadget *);
>> >>  };
>> >
>> > Since we already have get_charger_type callback at usb_charger
>> > structure, why we still need this API at usb_gadget_ops?
>>=20
>> In case some users want to get charger type at gadget level.
>>=20
> Why gadget needs to know charger type? I also don't catch the intent of

because some gadgets need to call usb_gadget_vbus_draw(), although for
that they need power in mA rather.

> This api, as my understanding, gadget only need report gadget state chang=
es.
> All information required for usb charger is charger type and gadget state.

you're making an assumption about how the HW is laid out which might not
be true.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJXBP9WAAoJEIaOsuA1yqREvBoP/0bM1+kVTc3WqDt1FmbXMppG
ltlJAxWespz9QrAGDXs1ZNMTz5AVeTh88VMcJsP6AmiMu8069x+pwYOJDmonmbt3
xkk+v3y4BpvfMmRiY+Uy//Fk7Eccd3NUgVFg2W6WTIClvYjK6aoawaZNlGOC4N2B
dWH0/YyKtL29GCkllsdsI9WnK9hN/zZRKo+1Ph03iIX5XPsac7eFFFSwEsOHXfoP
Sp2yMOrdetrVCTYUELqIUAvrWwuRzEt+ZtA1E0yJ1uFlKzXiSefnFC0Z9AzI2baB
62O3we34nOPUh5tldc1Kla5SThVXX093pU0/YbG0nd4CgA+EDr3ElDYXEwU1zlCZ
S8yOmri2jWZflLi+f9BEP65krikT0FcQvg6JosdUxB1KCaPf9kOeZ37/z1UHKVIJ
RUMPrYCNH2lX0KAHVzqyvBDd3AyKukQLHQwlVWwLaDnKGCO9V5vqf/4vYURXhHX0
+n9XohBQoZ0NV8XhxeOxMn+1aVIZwtnxOVfafd36f4sR8v51QLhoKPDiJvs75vFi
b2DDVUoLqT8pfBstAPtGCYHSvq390k+uHeg1xz6Mm4DLO9NlCSGmfcr4mzNiPSSn
jn2hk1esNUFP/TAwuhQDOWo27tNV3z4sbBb/D+3GJQ8vWbZsib2eqclTroyGBPrm
Uag0Oj3SJRyFH0U9Xy0s
=9iiG
-----END PGP SIGNATURE-----
--=-=-=--