Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755020AbcDFM3Z (ORCPT ); Wed, 6 Apr 2016 08:29:25 -0400 Received: from mga14.intel.com ([192.55.52.115]:6235 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbcDFM3Y (ORCPT ); Wed, 6 Apr 2016 08:29:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="asc'?scan'208";a="681725246" From: Felipe Balbi To: "Du\, Changbin" , Greg KH Cc: "linux-usb\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: RE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A05CE2D57@SHSMSX103.ccr.corp.intel.com> References: <1459931243-26405-1-git-send-email-changbin.du@intel.com> <20160406092509.GA29930@kroah.com> <0C18FE92A7765D4EB9EE5D38D86A563A05CE2D57@SHSMSX103.ccr.corp.intel.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 06 Apr 2016 15:24:32 +0300 Message-ID: <87y48q2adb.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1810 Lines: 62 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, (please make sure to break your lines at 80-characters. Documentation/email-clients.txt has several tips for different email clients ;-)) "Du, Changbin" writes: >> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc) >> > goto err1; >> > } >> > >> > + file =3D debugfs_create_file("fifo", S_IRUGO, root, dwc, >> &dwc3_fifo_fops); >> > + if (!file) { >> > + ret =3D -ENOMEM; >>=20 >> Um, no, that's not the error here. You shouldn't care at all about >> debugfs api call results. Just keep moving on here please. >>=20 >> thanks, >>=20 >> greg k-h > > Agree with you. I will create another patch to cleanup this piece of > code. cool, thanks > And I found a memory leak issue there, dwc->regset never > released. Will also fix it. good catch, thanks for fixing it. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXBQABAAoJEIaOsuA1yqREFnwP/0E5cD+fDK/xNc2x6QnWjFsz xT8UViQTcsYy6fKIODmwTBkxRCp4KkkYr6STFUvCd4iAp94QKXyTvteQGmVRWGIZ WHqBjIW2GY2rv7an3WLjymySAZ/qF6xkK3mxpEy/HwXI/iG34oDXqrDuRRL+OI/L bBYE2wjY7Eu9XKvIxOLA0oFr7Rb5y/wF3EJSUH5Xug/yM2maAMAG+JRi+hXp3pdV p1J/wA2n/SbgxRqknZ5gPkl9+aWcHTSvgdFB40eP4Vze0BgrNIUBALgQf2RSOx+7 DBBBqPKp9YalZcj0heNAiRSuE8+li/WVQygss1mSEbfSOADdR0/LmZx1iwExRwiW M4eNsKiPEkcudygtoDPWOqpH/2lEskdoVPkwSkFSrR6qssEKfQQz32zAX+mMBk1U u7SaQtPMAxNKHIG8iIIrzcc6lLvObPfZDL+jDUOHdY2jPG3ChbhGtcUAfxLMwQG/ EDh4OqUY0V5ARIprjuM5Xg7FU/LxyESKx/9JumKGqgz+tPJQuPb20Yh0vSHGX1Re yIkM5XVFtMvqycNRUU9GtNTgTy7IpYVQSiPclq0a8STDQ0VFP/VlK8PiC8cXNNLD m4lmvKG3fbe3TiZ/sEu3H31lJdr0dwuH85OgL+PTu2kDIv1CZLbRVC/GoSHn9iFN 3Hj9eEO+jJaaFhV0fVW/ =LCbm -----END PGP SIGNATURE----- --=-=-=--