Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755282AbcDFMw7 (ORCPT ); Wed, 6 Apr 2016 08:52:59 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:53120 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751264AbcDFMw4 (ORCPT ); Wed, 6 Apr 2016 08:52:56 -0400 Subject: Re: [PATCH 1/2] phy: Group vendor specific phy drivers To: Vivek Gautam References: <1459510156-9147-1-git-send-email-gautam.vivek@samsung.com> <56FE7234.5000505@ti.com> CC: Vivek Gautam , , Shiraz Hashim , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Maxime Ripard , Chen-Yu Tsai , Russell King - ARM Linux , "linux-arm-kernel@lists.infradead.org" , , "linux-kernel@vger.kernel.org" , , Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , "linux-omap@vger.kernel.org" , CPGS From: Kishon Vijay Abraham I Message-ID: <5705066A.8010903@ti.com> Date: Wed, 6 Apr 2016 18:21:54 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 10951 Lines: 223 Hi, On Friday 01 April 2016 07:05 PM, Vivek Gautam wrote: > Hi, > > > On Fri, Apr 1, 2016 at 6:05 AM, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Friday 01 April 2016 04:59 PM, Vivek Gautam wrote: >>> Adding vendor specific directories in phy to group >>> phy drivers under their respective vendor umbrella. >>> >>> Signed-off-by: Vivek Gautam >>> --- >>> >>> With growing number of phy drivers, it makes sense to >>> group these drivers under their respective vendor/platform >>> umbrella directory. >>> >>> Build-tested 'multi_v7_defconfig'. >>> >>> drivers/phy/Kconfig | 386 +--------------------- >>> drivers/phy/Makefile | 57 +--- >>> drivers/phy/bcom/Kconfig | 27 ++ >>> drivers/phy/bcom/Makefile | 3 + >>> drivers/phy/{ => bcom}/phy-bcm-cygnus-pcie.c | 0 >>> drivers/phy/{ => bcom}/phy-bcm-kona-usb2.c | 0 >>> drivers/phy/{ => bcom}/phy-brcmstb-sata.c | 0 >>> drivers/phy/hisi/Kconfig | 20 ++ >>> drivers/phy/hisi/Makefile | 2 + >>> drivers/phy/{ => hisi}/phy-hi6220-usb.c | 0 >>> drivers/phy/{ => hisi}/phy-hix5hd2-sata.c | 0 >>> drivers/phy/marvell/Kconfig | 50 +++ >>> drivers/phy/marvell/Makefile | 6 + >>> drivers/phy/{ => marvell}/phy-armada375-usb2.c | 0 >>> drivers/phy/{ => marvell}/phy-berlin-sata.c | 0 >>> drivers/phy/{ => marvell}/phy-berlin-usb.c | 0 >>> drivers/phy/{ => marvell}/phy-mvebu-sata.c | 0 >>> drivers/phy/{ => marvell}/phy-pxa-28nm-hsic.c | 0 >>> drivers/phy/{ => marvell}/phy-pxa-28nm-usb2.c | 0 >>> drivers/phy/qcom/Kconfig | 23 ++ >>> drivers/phy/qcom/Makefile | 5 + >>> drivers/phy/{ => qcom}/phy-qcom-apq8064-sata.c | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ipq806x-sata.c | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ufs-i.h | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-14nm.c | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-14nm.h | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-20nm.c | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-20nm.h | 0 >>> drivers/phy/{ => qcom}/phy-qcom-ufs.c | 0 >>> drivers/phy/rcar/Kconfig | 16 + >>> drivers/phy/rcar/Makefile | 2 + >>> drivers/phy/{ => rcar}/phy-rcar-gen2.c | 0 >>> drivers/phy/{ => rcar}/phy-rcar-gen3-usb2.c | 0 >>> drivers/phy/rockchip/Kconfig | 23 ++ >>> drivers/phy/rockchip/Makefile | 3 + >>> drivers/phy/{ => rockchip}/phy-rockchip-dp.c | 0 >>> drivers/phy/{ => rockchip}/phy-rockchip-emmc.c | 0 >>> drivers/phy/{ => rockchip}/phy-rockchip-usb.c | 0 >>> drivers/phy/samsung/Kconfig | 87 +++++ >>> drivers/phy/samsung/Makefile | 10 + >>> drivers/phy/{ => samsung}/phy-exynos-dp-video.c | 0 >>> drivers/phy/{ => samsung}/phy-exynos-mipi-video.c | 0 >>> drivers/phy/{ => samsung}/phy-exynos4210-usb2.c | 0 >>> drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c | 0 >>> drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c | 0 >>> drivers/phy/{ => samsung}/phy-exynos5250-sata.c | 0 >>> drivers/phy/{ => samsung}/phy-exynos5250-usb2.c | 0 >>> drivers/phy/{ => samsung}/phy-s5pv210-usb2.c | 0 >>> drivers/phy/{ => samsung}/phy-samsung-usb2.c | 0 >>> drivers/phy/{ => samsung}/phy-samsung-usb2.h | 0 >>> drivers/phy/st/Kconfig | 51 +++ >>> drivers/phy/st/Makefile | 6 + >>> drivers/phy/{ => st}/phy-miphy28lp.c | 0 >>> drivers/phy/{ => st}/phy-miphy365x.c | 0 >>> drivers/phy/{ => st}/phy-spear1310-miphy.c | 0 >>> drivers/phy/{ => st}/phy-spear1340-miphy.c | 0 >>> drivers/phy/{ => st}/phy-stih407-usb.c | 0 >>> drivers/phy/{ => st}/phy-stih41x-usb.c | 0 >>> drivers/phy/sunxi/Kconfig | 28 ++ >>> drivers/phy/sunxi/Makefile | 2 + >>> drivers/phy/{ => sunxi}/phy-sun4i-usb.c | 0 >>> drivers/phy/{ => sunxi}/phy-sun9i-usb.c | 0 >>> drivers/phy/ti/Kconfig | 67 ++++ >>> drivers/phy/ti/Makefile | 6 + >>> drivers/phy/{ => ti}/phy-dm816x-usb.c | 0 >>> drivers/phy/{ => ti}/phy-omap-control.c | 0 >>> drivers/phy/{ => ti}/phy-omap-usb2.c | 0 >>> drivers/phy/{ => ti}/phy-ti-pipe3.c | 0 >>> drivers/phy/{ => ti}/phy-tusb1210.c | 0 >>> drivers/phy/{ => ti}/phy-twl4030-usb.c | 0 >>> drivers/phy/{ => ti}/ulpi_phy.h | 0 >> >> ulpi_phy.h is not specific to TI though at this point tusb1210 is the only ULPI >> driver. > > Yes, you are right. But i was hesitant to add a multi-level header > file include in the phy driver > which uses it. > > Does it makes sense to move this ulpi_phy.h to include/linux/phy ? yeah.. that should be okay. > >>> 71 files changed, 464 insertions(+), 416 deletions(-) >>> create mode 100644 drivers/phy/bcom/Kconfig >>> create mode 100644 drivers/phy/bcom/Makefile >>> rename drivers/phy/{ => bcom}/phy-bcm-cygnus-pcie.c (100%) >>> rename drivers/phy/{ => bcom}/phy-bcm-kona-usb2.c (100%) >>> rename drivers/phy/{ => bcom}/phy-brcmstb-sata.c (100%) >>> create mode 100644 drivers/phy/hisi/Kconfig >>> create mode 100644 drivers/phy/hisi/Makefile >>> rename drivers/phy/{ => hisi}/phy-hi6220-usb.c (100%) >>> rename drivers/phy/{ => hisi}/phy-hix5hd2-sata.c (100%) >>> create mode 100644 drivers/phy/marvell/Kconfig >>> create mode 100644 drivers/phy/marvell/Makefile >>> rename drivers/phy/{ => marvell}/phy-armada375-usb2.c (100%) >>> rename drivers/phy/{ => marvell}/phy-berlin-sata.c (100%) >>> rename drivers/phy/{ => marvell}/phy-berlin-usb.c (100%) >>> rename drivers/phy/{ => marvell}/phy-mvebu-sata.c (100%) >>> rename drivers/phy/{ => marvell}/phy-pxa-28nm-hsic.c (100%) >>> rename drivers/phy/{ => marvell}/phy-pxa-28nm-usb2.c (100%) >>> create mode 100644 drivers/phy/qcom/Kconfig >>> create mode 100644 drivers/phy/qcom/Makefile >>> rename drivers/phy/{ => qcom}/phy-qcom-apq8064-sata.c (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ipq806x-sata.c (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ufs-i.h (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-14nm.c (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-14nm.h (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-20nm.c (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ufs-qmp-20nm.h (100%) >>> rename drivers/phy/{ => qcom}/phy-qcom-ufs.c (100%) >>> create mode 100644 drivers/phy/rcar/Kconfig >>> create mode 100644 drivers/phy/rcar/Makefile >>> rename drivers/phy/{ => rcar}/phy-rcar-gen2.c (100%) >>> rename drivers/phy/{ => rcar}/phy-rcar-gen3-usb2.c (100%) >>> create mode 100644 drivers/phy/rockchip/Kconfig >>> create mode 100644 drivers/phy/rockchip/Makefile >>> rename drivers/phy/{ => rockchip}/phy-rockchip-dp.c (100%) >>> rename drivers/phy/{ => rockchip}/phy-rockchip-emmc.c (100%) >>> rename drivers/phy/{ => rockchip}/phy-rockchip-usb.c (100%) >>> create mode 100644 drivers/phy/samsung/Kconfig >>> create mode 100644 drivers/phy/samsung/Makefile >>> rename drivers/phy/{ => samsung}/phy-exynos-dp-video.c (100%) >>> rename drivers/phy/{ => samsung}/phy-exynos-mipi-video.c (100%) >>> rename drivers/phy/{ => samsung}/phy-exynos4210-usb2.c (100%) >>> rename drivers/phy/{ => samsung}/phy-exynos4x12-usb2.c (100%) >>> rename drivers/phy/{ => samsung}/phy-exynos5-usbdrd.c (100%) >>> rename drivers/phy/{ => samsung}/phy-exynos5250-sata.c (100%) >>> rename drivers/phy/{ => samsung}/phy-exynos5250-usb2.c (100%) >>> rename drivers/phy/{ => samsung}/phy-s5pv210-usb2.c (100%) >>> rename drivers/phy/{ => samsung}/phy-samsung-usb2.c (100%) >>> rename drivers/phy/{ => samsung}/phy-samsung-usb2.h (100%) >>> create mode 100644 drivers/phy/st/Kconfig >>> create mode 100644 drivers/phy/st/Makefile >>> rename drivers/phy/{ => st}/phy-miphy28lp.c (100%) >>> rename drivers/phy/{ => st}/phy-miphy365x.c (100%) >>> rename drivers/phy/{ => st}/phy-spear1310-miphy.c (100%) >>> rename drivers/phy/{ => st}/phy-spear1340-miphy.c (100%) >>> rename drivers/phy/{ => st}/phy-stih407-usb.c (100%) >>> rename drivers/phy/{ => st}/phy-stih41x-usb.c (100%) >>> create mode 100644 drivers/phy/sunxi/Kconfig >>> create mode 100644 drivers/phy/sunxi/Makefile >>> rename drivers/phy/{ => sunxi}/phy-sun4i-usb.c (100%) >>> rename drivers/phy/{ => sunxi}/phy-sun9i-usb.c (100%) >>> create mode 100644 drivers/phy/ti/Kconfig >>> create mode 100644 drivers/phy/ti/Makefile >>> rename drivers/phy/{ => ti}/phy-dm816x-usb.c (100%) >>> rename drivers/phy/{ => ti}/phy-omap-control.c (100%) >>> rename drivers/phy/{ => ti}/phy-omap-usb2.c (100%) >>> rename drivers/phy/{ => ti}/phy-ti-pipe3.c (100%) >>> rename drivers/phy/{ => ti}/phy-tusb1210.c (100%) >>> rename drivers/phy/{ => ti}/phy-twl4030-usb.c (100%) >>> rename drivers/phy/{ => ti}/ulpi_phy.h (100%) >>> >>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig >>> index 26566db..80c8c68 100644 >>> --- a/drivers/phy/Kconfig >>> +++ b/drivers/phy/Kconfig >>> @@ -15,45 +15,6 @@ config GENERIC_PHY >>> phy users can obtain reference to the PHY. All the users of this >>> framework should select this config. >>> >> >>> +menuconfig PHY_PLAT >>> + bool "Platform Phy drivers" >> >> Not really convinced about adding a new config here. This will create new >> dependencies and will also start breaking users of oldconfig. > > This serves including all the directory paths in the 'make' for > driver/phy/Makefile. > > Otherwise each directory will have to be built as per particular platform > And, not all drivers of a vendor are built for one-kind of platform, > for example, Samsung uses ARCH_EXYNOS, as well as ARCH_S5PV210 > Similarly, Broadcom phy drivers are based on multiple platforms, and so > does Marvell's. > > Please suggest a concise way to include the vendor directories in the build path > in drivers/phy/Makefile. obj-y += vendor/? -Kishon > >> >> Also not all of them are platform drivers (e.g ULPI PHY drivers). > I Think this applies to ulpi_phy only at this moment, which we can resolve > by moving that to include/linux path. > >> >> Thanks >> Kishon >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > >