Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755132AbcDFNIP (ORCPT ); Wed, 6 Apr 2016 09:08:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53277 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751065AbcDFNIO (ORCPT ); Wed, 6 Apr 2016 09:08:14 -0400 Reply-To: xlpang@redhat.com Subject: Re: [PATCH] sched/deadline: No need to check NULL later_mask References: <1459509198-26543-1-git-send-email-xlpang@redhat.com> <20160401112919.GP3430@twins.programming.kicks-ass.net> <56FE66A5.9050004@redhat.com> <20160401162136.GM3448@twins.programming.kicks-ass.net> <56FF9B84.2030307@redhat.com> <20160406093036.GQ3448@twins.programming.kicks-ass.net> To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, Juri Lelli , Ingo Molnar , Steven Rostedt From: Xunlei Pang Message-ID: <57050A32.9000009@redhat.com> Date: Wed, 6 Apr 2016 21:08:02 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160406093036.GQ3448@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 06 Apr 2016 13:08:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 22 On 2016/04/06 at 17:30, Peter Zijlstra wrote: > On Sat, Apr 02, 2016 at 06:14:28PM +0800, Xunlei Pang wrote: >> Your proposal is very nice! >> >> At the sched_init() stage we only have one (to be "idle") task and with irq disabled, >> no scheduling will happen, and the cpu_possible_mask was already initiated, so it's >> safe to simply move them there. >> >> Also, how about rt&deadline sharing a percpu mask? Because only one of them can >> use the mask at a moment, operations are always under some spin_lock_irqsave(). >> >> I made a new patch below, slightly tested by running tens of rt&dl tasks for a while, >> are you fine with it? > Yep, looks fine. Please submit as a proper patch. Will do, thanks! Regards, Xunlei > > Thanks!