Subject: Re: [PATCH v2 09/30] Add tile-specific parity functions
To: <zengzhaoxiu@163.com>
References: <57031D9D.801@gmail.com>
 <1459933716-6990-1-git-send-email-zengzhaoxiu@163.com>
CC: <linux-kernel@vger.kernel.org>, Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
From: Chris Metcalf <cmetcalf@mellanox.com>
Message-ID: <57050EC5.3090604@mellanox.com>
Date: Wed, 6 Apr 2016 09:27:33 -0400
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1459933716-6990-1-git-send-email-zengzhaoxiu@163.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2016 13:27:54.9235 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1691
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 566
Lines: 16

On 4/6/2016 5:08 AM, zengzhaoxiu@163.com wrote:
> From: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com>
>
> Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com>
> ---
>   arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)

Since all the code you are adding here is architecture-independent,
I think it would make more sense to have it be in a file like
include/asm-generic/bitops/parity-popcount.h, which can then
be included from arch/tile/include/asm/bitops.h.

-- 
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com