Date: Wed, 6 Apr 2016 16:17:37 +0200 (CEST)
From: Miroslav Benes <mbenes@suse.cz>
To: Chris J Arges <chris.j.arges@canonical.com>
cc: Josh Poimboeuf <jpoimboe@redhat.com>, Jiri Kosina <jikos@kernel.org>,
        jeyu@redhat.com, eugene.shatokhin@rosalab.ru,
        live-patching@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        pmladek@suse.cz
Subject: Re: Bug with paravirt ops and livepatches
In-Reply-To: <20160406134833.GA12961@canonical.com>
Message-ID: <alpine.LNX.2.00.1604061615550.30748@pobox.suse.cz>
References: <alpine.LNX.2.00.1604011546110.16158@cbobk.fhfr.pm> <alpine.LNX.2.00.1604011745370.27264@pobox.suse.cz> <20160401190704.GB7837@canonical.com> <alpine.LNX.2.00.1604012132430.16158@cbobk.fhfr.pm> <20160404161428.3qap2i4vpgda66iw@treble.redhat.com>
 <alpine.LNX.2.00.1604051445530.1180@pobox.suse.cz> <20160405232729.GA18198@canonical.com> <alpine.LNX.2.00.1604061103390.27016@pobox.suse.cz> <20160406103821.GA4968@canonical.com> <alpine.LNX.2.00.1604061406080.30748@pobox.suse.cz>
 <20160406134833.GA12961@canonical.com>
User-Agent: Alpine 2.00 (LNX 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1664
Lines: 45

On Wed, 6 Apr 2016, Chris J Arges wrote:

> On Wed, Apr 06, 2016 at 02:09:01PM +0200, Miroslav Benes wrote:
> > On Wed, 6 Apr 2016, Chris J Arges wrote:
> > 
> > > I think this approach needs more thought and my code has bug(s).
> > 
> > And indeed there is...
> > 
> > long (*__kvm_arch_vm_ioctl)(struct file *filp, unsigned long ioctl, unsigned long arg) = NULL;
> > 
> > Use a different name than __kvm_arch_vm_ioctl and (ideally) make it 
> > static.
> > 
> > kallsyms_lookup_name("__kvm_arch_vm_ioctl") returns the address of this 
> > variable from the patch module.
> > 
> > Miroslav
> >
> 
> Well that was the bug, I was really stumped why it was giving me a wierd
> address for a function. Once I changed my pointer name to something else it
> worked, so there was no difference to these approaches. I also had to modify
> the symbol lookup to happen in the livepatch so we ensure that the module is
> loaded in this case and not get a NULL deref.

Just a remark. With this change there is a call to kallsyms_lookup_name 
for each call to patched function. This is not optimal. What we do in 
kgraft is that we register a module notifier which calls 
kallsyms_lookup_name when to-be-patched module arrives. It is not nice but 
it works.

Miroslav

> 
> The fixed code is here:
> http://people.canonical.com/~arges/livepatch_issue/livepatch_kvm_arch_vm_ioctl.works.2/
> 
> This out of tree patch doesn't have the same failure as building a patch with
> kpatch-build which is what we expect since it doesn't have livepatch relocs. In
> addition I tested with the kvm module loaded _after_ the livepatch module and
> no failure was observed.
> 
> --chris
>