Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753579AbcDFO2U (ORCPT ); Wed, 6 Apr 2016 10:28:20 -0400 Received: from mail-bn1bon0094.outbound.protection.outlook.com ([157.56.111.94]:37632 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751827AbcDFO2R (ORCPT ); Wed, 6 Apr 2016 10:28:17 -0400 X-Greylist: delayed 865 seconds by postgrey-1.27 at vger.kernel.org; Wed, 06 Apr 2016 10:28:16 EDT Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; cumulusnetworks.com; dkim=none (message not signed) header.d=none;cumulusnetworks.com; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-5f3ff70000000be7-a3-5705197235c9 Subject: Re: [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()" To: Bjorn Helgaas , "David S. Miller" References: <20160405205822.24724.95522.stgit@bhelgaas-glaptop2.roam.corp.google.com> CC: Neil Horman , Nikolay Aleksandrov , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Alexander Duyck From: Bart Van Assche Message-ID: <57051999.3080209@sandisk.com> Date: Wed, 6 Apr 2016 07:13:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160405205822.24724.95522.stgit@bhelgaas-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmphkeLIzCtJLcpLzFFi42JZI8azSLdIkjXc4NJqAYu9x6QsljRlWMw5 38JicXnXHDaLYwvELFr/zWG3uD1pFrsDu8ePjXuYPbasvMnksWBTqUf/xO9MHu/3XWXz+LxJ LoAtissmJTUnsyy1SN8ugSvjyJfVbAXbmStundnO2sD4kamLkZNDQsBE4lbDHSCbi0NIYC6T xOMPU1lAEkIC2xkllq8ShCk6N+MzI1QRo8SUeQ9ZQRLCAhESv77eAZskIhAkMfXGImaI5lCJ hQ+3soM0MAt8Y5Q4Pes7WAObgJHEt/czwTbwCmhJTP6+E6yBRUBFovH6TEYQWxRoaOuDp+wQ NYISJ2c+AavnFAiT+LngPFgNs4CFxMz5MLa8xPa3c5hBlkkInGSV+LHoBzvEFeoSJ5fMZ5rA KDwLyaxZSPpnIelfwMi8ilEsNzOnODc9tcDQVK84MS8lszhbLzk/dxMjJG4ydzDefeJ9iFGA g1GJh1fAiiVciDWxrLgy9xCjBAezkgjvLDHWcCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8bve+ hAkJpCeWpGanphakFsFkmTg4pRoYT9yQZk6VE3i2YfahsqZPssHrgntWMGxqf7ja4KxN493T YZ1qTRu6vR/IPF9V3rjv6Pyb6k1bveL/yEwy3DR/dui3j/0fZZ/t5H1+4I6BWFHG/qnbMn7+ 9OWLteapOrk73O+1QPy1s4dEGe4eto9Y47FzxpqAnPbt17XyRX/O3+rbfWdhZO6yTiWW4oxE Qy3mouJEAJ/LtWCXAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFJMWRmVeSWpSXmKPExsXCtZEjRXeWJGu4weotzBZ7j0lZLGnKsJhz voXF4vKuOWwWxxaIWbT+m8NucXvSLHYHdo8fG/cwe2xZeZPJY8GmUo/+id+ZPN7vu8rm8XmT XABbFJdNSmpOZllqkb5dAlfGkS+r2Qq2M1fcOrOdtYHxI1MXIyeHhICJxLkZnxm7GLk4hARm M0q0nW9nAUkIC0RI/Pp6B6xIRCBI4vSXVrC4kECoxMKHW9lBGpgFfjBKHD4+hxEkwSZgJPHt /UywIl4BLYnJ33cyg9gsAioSjddngtWIAg1tffCUHaJGUOLkzCdg9ZwCYRI/F5wHq2EWMJOY t/khM4QtL7H97RzmCYx8s5C0zEJSNgtJ2QJG5lWMYrmZOcW56ZkFhoZ6xYl5KZnF2XrJ+bmb GMGhyxm5g/HpRPNDjEwcnFINjKobHsytqLgstzF53t/Pd88GT3mq5yNtckHeJTHrZt/hX9IF f1LU2zd9dqycWtMs6z7Rbm6SMRcz18fWQtZpi3K1WQ1XsquIzjOJ7JOUF83Re3IwL975p07u KzvFNsdoVp2o6XkRO/UvrefbmbS5LiElxvn+nKRKZZcnkYskyjRTHSwrt81SYinOSDTUYi4q TgQANbWPEA0CAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(24454002)(76176999)(54356999)(87266999)(65816999)(19580405001)(19580395003)(50986999)(86362001)(83506001)(11100500001)(106466001)(23676002)(59896002)(87936001)(117636001)(5008740100001)(6806005)(4001350100001)(65956001)(65806001)(5001770100001)(189998001)(230700001)(47776003)(122286003)(64126003)(92566002)(2270400002)(81166005)(2906002)(36756003)(2950100001)(77096005)(586003)(50466002)(4326007)(1220700001)(1096002)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR0201MB1936;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC002;1:9UVUjD90fgPiIPPt/9ua6zZE/p+D7dlmEmVO2/y6X+bKYoxMB7WOMV4SYEuYA3GXdOAeXfN3AB1OcjdHmW+WplyFfXBKMJSVpanlu2vfYMd4x9MJiwADW2d/7cL1dGkig2YxCxkWtoE6UIcQ2iSlig6jmncz245W5Z40UWDkEJA9LRc6w1LdUtEPrq/supv4oVlYRXXXCEQkJJrSudIcvAbMZ0MwqrqIGM1PWeI6zAKZFyZeN0kNwi1RVx84yfm0Gx6PquOidI5pfdqqQuZeFNXcT7edbQspaieo2n+kE0TMksivuiEb9EkSf9wSenELn7vAMVRkyXvpTCRGKFBYAeZ7WLiiOseAx3D0FRfa+fqXOFC9IIN7Z2Yt6nkRuFyEpD/tT7TB4l1SrD0hfdk8GHBRPWPfVWErDUH8yJWerQ67Pf280Rmairt+ztimy3CzgPt/3RsTtA3MXpC7NTTNh9nZB7V0ejzOIplW9/ax+os= X-MS-Office365-Filtering-Correlation-Id: a5c3fe3d-34ee-44f4-e8e0-08d35e25ab69 X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;2:YqjdjW7oKcgQr98UylzH5C1htwGineb+bbWlfTtU636jQfkYWKe3XzyyHd+8uDPWVrbwr61HrEdgJZDAgmLUpZk7IEiOHESCJsS7Deo8PX5EIfAgzSsNphoBDdEmL03NvWW86R4UA7NikP+vPKJs6tnDBUKrgCsJxOveIcL9sH/ho6nCkXXoLka6JkUlqx1F;3:W/H2C64QzmnYKq2bB3yKJXBXWo4I8upeRM3/dY7hudSuK2D55jRzOwYAsCj9lIRCvJenv/YbWHWDbh0iFrCBoF2pnF5StcPGrFBvDN+L0gsc7hnDFjugg5n/nbGxR19FiwtykVrJ71vwS2PjBlfzyatrnYcWFdo0Bx+CHQsoR+3J+a78P0sam16CIUP/m6oQ0AFf3VZcIVwD1nvMH6BChIumtKyS0Rbt3NTzq18IyLBWcsx3/+5eV2YLwFlA1MHz9pMWL5DN19SOgjtdtC0M/A==;25:VkAvgaKNNHWOZVkVqXHE+v+gdB5PtfnlUOw7PcANC59c8xKfaljO59DzH4iMZTxPev/wGlVcvRuj5kfvmB7YScgKf/+nhoOsK9O2UUq3+t4PzlqFCyQS79a7Btc0N7KDS+y6VcWJHPXy/MEgIG/hQeEFZU2TY6P4/onaCahO3efUqbDntQ6YhiumWJoby4c4AAB/CLwJVqO37D9eG1YKHlpBe+Qoy7uw26xdIH1wRtQqAa30bq2neGElD2Xmzj+1RPuP3AaXIv+eYLKYomB32Ayx6ScgYgAfkxveiRT3ed/Q5rIrr3ajVP9SUEmMA443UEHLuFe5PfHPIuUunNCrTw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:SN1PR0201MB1936; X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;20:EvWACRD69L9dDIX2uXckONQ8jF79Tv4kD9KGAQpvvUFpvERFrkknP3nznKSpLRTKR5ffMbZlpYKiepGTGVolHEkJXOD1Pqse9QK+/oU96cMeyZNjIX3XLjibVv+iNo69I77GH8mGsOmSmBbiCuzr0gD/T92slBaEFMnaWlVQXTa72aGdQIgX6UWRFwtn2/Tbzwj3LrSZSrDFCm0QAKqbG8/K+GURGIeYvmUJ93e6SESrzsnAQL+NenvqSY5zjLapAIfbNNIFhU2RgcYTIzFzLeWsboTSrLGeQn/yeeH4hbMVScTf8xh7fTeCQO2aEuSDMO6hEy1fsh4M3BlUxetCAixSQXXL3p1E6e0AcpmSgW/fauhFdyNkT6sSn4n1mkWrhJnSiVUrRiK1R2SOV8MCBgLOrFJhxIeAQ7jytKKtYf0sQdoCNcXsq0MxRL5oQwWH+kB5zh2jNsTlENFnbB5NxJDT7aBTK1ocUypUVzHOR0K/OOutLJI+bo4nw33sRSn8;4:slRHzLSPhvN8xWT/p8T3XnjalCvz2UT4IhhlphwxcFhZFXhQZ18sk+7Cr3QFFuRtQfLXIRLLuqQY+cnMiiYnpxp+lm43d+PI9cR5eSp/irh79+cj3dM+A7kL1yZ/SvKeuF0Kg65p2iVHKd5ipuhTqBW77C+fPY+71pQpaQZIY18GGo3xGb1kgGZlmAzri6jDJeYqBOvRRjbNv4Ujwum5xc3llRluqblWJJtIdWVOeeRV0lsog+30zSyG03KSIqmKpUaC3GKENcjyyk9TSXARLTE487B501meoyt5UyTd1sdPmgA8IS7o7aHl1yLxnqeqsSUD/lCv0wxgEfhPaib9DAJBLkcT7ngL219A7Ym2RHwQzOY/e0pkm8GM+Q7n6qpl5ybagp0E+F4gcCdEmCYTtQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13016025)(5005006)(13018025)(8121501046)(10201501046)(3002001);SRVR:SN1PR0201MB1936;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0201MB1936; X-Forefront-PRVS: 0904004ECB X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjAyMDFNQjE5MzY7MjM6T3pKMmNoaTZudHNFMGRSLzlQVWViK0dD?= =?utf-8?B?aFhVZnlrZ3d6anlSQWhIbU0vVExuVzVPdDNMWTRCVElpVHA1Sml4L0ltM0Zl?= =?utf-8?B?RTNPNUV1UGxFa3hJZ2lmZmtKTEN4NTRUU256ekR6Ykh1bmxVTnJBdUtkWEQz?= =?utf-8?B?WVMra2FIZ28vS0J3MTRHUWRrUnN0VXVjaXhBYkRNWTByOEhCMkZxS1VhUCsz?= =?utf-8?B?UFdKNVFDdHN3dldVeU5mWTU0ZThkY2ZCekhqZVNzeUw3ZFRaUGRMWXZXd0VQ?= =?utf-8?B?MVBKZkZId0Y1NVVQSXR0eVpKY0pkdHFhaWlPUG1SYnNWYnc4NjFCUW82Z3FY?= =?utf-8?B?YTlsU3RZSUFzWGdWM3ZCYlVNdTcwSHNaZlYwWEh0Y1djczBkVS9UN2pDNFdy?= =?utf-8?B?UGxhQk11bkZuOHhGTlM0OVNMQXVKUk9pZzU0UVlYYko4RjNOakhQaGR5Rk5K?= =?utf-8?B?WURINkd1aHE4ZTFOMDB3ZXNQS2VseWRqWWEvQnFvNE11cFNhRGRBTjY5aGlv?= =?utf-8?B?aVFUcE80dDJkZ0oycEswVCtDRVBOMWt0RURtNXZCd25uakZGTUtnRFhIREtw?= =?utf-8?B?Y29kbFR6REdzY00zU21UQzFES0VXNUl4WkxsZWtBTHdrRTl3V1BaV1EvZFVn?= =?utf-8?B?OWlHTGVQVXNyYzFoQks5OE5nL0dxdHlHVlBCV3Y5RThrWUpEV3o0b1lWU2Fq?= =?utf-8?B?eVNlWmtiQVFKM2hacElHYjhpdkMvWDdNUlZnaFFsd0VRcU9ZN09zYmh6Zi80?= =?utf-8?B?am5IRFlRRUlkVW9wb3ozTVNIeUx0RlJnRDF5ZEZuRzEyMHVZVzY0YThURWVl?= =?utf-8?B?M2lmNTA2c1hqWVJKUFZzYVpsQXk5bnZlbzZXeWdUaUFKQTV0Q1BjS3FsOGpk?= =?utf-8?B?c1YxVE4rYnl4NkJmM1pmZzRHQWRvUVlaRThtUXdoWGwwZ1FtcHVDTFRMY0hM?= =?utf-8?B?S2xpRDBMMGxqTDNpN2VVcEMzaDNpMFppTW9SamhRbUJ1bDFIRGpLNHBhQjVU?= =?utf-8?B?d0dXMjZTUS8rcmE0bHI1S3NCVFIvV09YWHo5dXVreXFJeThabUpmL0hNQzVR?= =?utf-8?B?dE4wOXlvNVBWeExtTURrTk5PczJpVEgySkZ5TklyYlFNZ09QaW9QUjFSc3I4?= =?utf-8?B?THVUUkQ0QTl0dTlsSndFc1RUZjFVVWN2YUJxL1RWck4wRXpzc0ovOXc1SVBt?= =?utf-8?B?M3NrTkJaMVdYeU5wb28vL1ozY0I3WElGa2YxOTVMV3R4WWQxTEYyODd0VVNR?= =?utf-8?B?L3ZnOHZUUlVraEgvaGxBYW5kZVBPZ0tJRGxGV0xmV2dIeVBEbGg3TTdpWkhN?= =?utf-8?B?VVM4QlRhRkNnMFV2M0Era0xNbzdFd2VkYlhDYzRYUFBWMC94Tzk2V0RYSElv?= =?utf-8?B?enplQis1eDd4QkdacXpaK0E5Lzl0ZjU4a0w3RlhFUUNERzFJaDQydk4rN2dT?= =?utf-8?B?ZEJ5U0NIemNEdzJQUFdEYTJhbDhZdmVlYjdERFZVT0daWkdzNUlBNDRJNFY4?= =?utf-8?B?Y3gvWG44K2tJSXVERDJpQW9vRGtGRWJkQkJPdVJwUHNQNk5HSU9ZRUx4Qnp4?= =?utf-8?B?NVkwYS81NHBBWTVZcnYyQmRrRnJEZDR2Zz09?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR0201MB1936;5:PexTPUxudGNqtayAEF6fqvHFsKeIP3T9qggkLCACWgFqUkksdCVAv87jwR34ZlcF9YG4lH5R/mn27JgnL85Mq0fS9py57BKqUGRcMqkkMb2AXHmz0lnNX/jrNkNATv+4jKWxjuKu6mMvaXLHrTwcGA==;24:HVIjOTvZtoj35nGk4WiwLP1W/HBWpJe1YR+U0I/0JOVU7AmUuAVyL7P7yvvygjOSyqO6eU9eIitUjnLE56GNAnLjJQ82zBwkHV0AHpAscZw=;20:e2aP/TXRoDnaRENZgvIE0W/ribukUz32xMdf3kzjEgj8oTo0ukOi+3Sybe4KIjNhRFpuph2QOOo2YWMtnC5qtphBgmrmOOAC96JlnnjKAuPsTuWhxkq57dJaQq+QfAN5YNe8lGGIihg3QDIY/IJgKhDGhjxCv93bfX3Qnv0pgx1cVGEEHusYXcHKtyMblUe9834LMgj4M+oWzGd9S6ACKWCx643Xc+9tzF35k7nbxTyYoyVfK66q51CksR5XbQDD SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2016 14:13:47.1237 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0201MB1936 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 425 Lines: 14 On 04/05/16 13:58, Bjorn Helgaas wrote: > This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7. > > Direct callers of __netpoll_setup() depend on it to set np->dev, > so we can't simply move that assignment up to netpoll_stup(). > > Reported-by: Bart Van Assche > Signed-off-by: Bjorn Helgaas Tested-by: Bart Van Assche Thanks! Bart.