Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753512AbcDFO5i (ORCPT ); Wed, 6 Apr 2016 10:57:38 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:39943 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751320AbcDFO5g (ORCPT ); Wed, 6 Apr 2016 10:57:36 -0400 Message-ID: <570523B0.6070600@st.com> Date: Wed, 6 Apr 2016 16:56:48 +0200 From: Giuseppe CAVALLARO User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Vineet Gupta , Alexey Brodkin , CC: Rob Herring , Phil Reid , "David S. Miller" , , , Gabriel Fernandez , Sergei Shtylyov Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts References: <1458207712-29435-1-git-send-email-abrodkin@synopsys.com> <5704D2ED.4060507@synopsys.com> In-Reply-To: <5704D2ED.4060507@synopsys.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.33] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-04-06_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2545 Lines: 83 On 4/6/2016 11:12 AM, Vineet Gupta wrote: > Hi, > > On Thursday 17 March 2016 03:11 PM, Alexey Brodkin wrote: >> Following commit broke DW GMAC functionality on AXS10x boards: >> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 >> >> That's what happens on eth0 up: >> --------------------------->8------------------------ >> libphy: PHY stmmac-0:ffffffff not found >> eth0: Could not attach to PHY >> stmmac_open: Cannot attach to PHY (error: -19) >> --------------------------->8------------------------ >> >> Simplest solution is to add PHY description in board's .dts. >> And so we do here. >> >> Signed-off-by: Alexey Brodkin >> Cc: Rob Herring >> Cc: Phil Reid >> Cc: David S. Miller >> Cc: linux-kernel@vger.kernel.org >> Cc: netdev@vger.kernel.org >> Cc: stable@vger.kernel.org # 4.5.x >> Cc: Sergei Shtylyov >> --- >> >> Changes v1 -> v2: >> * PHY node name changed to match real PHY number being used (Sergei) >> >> arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi >> index 44a578c..ab5d570 100644 >> --- a/arch/arc/boot/dts/axs10x_mb.dtsi >> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi >> @@ -47,6 +47,14 @@ >> clocks = <&apbclk>; >> clock-names = "stmmaceth"; >> max-speed = <100>; >> + mdio0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + compatible = "snps,dwmac-mdio"; >> + phy1: ethernet-phy@1 { >> + reg = <1>; >> + }; >> + }; >> }; >> >> ehci@0x40000 { > > > So above DT fix for ARC went into 4.6-rc1 and ethernet was still broken on axs103 > board. > > ---------->8------------- > libphy: PHY stmmac-0:ffffffff not found > eth0: Could not attach to PHY > stmmac_open: Cannot attach to PHY (error: -19) > ---------->8------------- > > On 4.6-rc2 if I revert the DT change, ethernet works again. > > @Giuseppe, @Phil, @Gabriel, I see you have made changes in that area. I presume > that above revert is the right/sufficient thing or do we need to do something else > as well. hmm I think so, we pushed all the changes in net-next to fix the MDIO initialization according to the different DT parameter settings. So unless there is some other case to cover, I think that the best approach is to do the revert. pls, let me know peppe > > TIA, > -Vineet > >