Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbcDFPLx (ORCPT ); Wed, 6 Apr 2016 11:11:53 -0400 Received: from mga02.intel.com ([134.134.136.20]:51760 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754825AbcDFPLv (ORCPT ); Wed, 6 Apr 2016 11:11:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,447,1455004800"; d="scan'208";a="779315175" Subject: Re: [PATCH 1/4] KVM: MMU: fix permission_fault() To: Paolo Bonzini References: <1458911978-19430-1-git-send-email-guangrong.xiao@linux.intel.com> <5704CF4D.9080905@redhat.com> Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Xiao Guangrong Message-ID: <570526B6.4040909@linux.intel.com> Date: Wed, 6 Apr 2016 23:09:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5704CF4D.9080905@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 488 Lines: 17 On 04/06/2016 04:56 PM, Paolo Bonzini wrote: > > > On 25/03/2016 14:19, Xiao Guangrong wrote: >> @@ -193,11 +193,11 @@ static inline u8 permission_fault(struct kvm_vcpu *vcpu, struct kvm_mmu *mmu, >> ((pte_access & PT_USER_MASK) << (PFERR_RSVD_BIT - PT_USER_SHIFT)); > > One more tweak is needed in the line above; pfec - 1 must become pfec & > ~1, because you've removed the > > pfec |= PFERR_PRESENT_MASK; > > line. Applied with this change. Yes, indeed. Thanks for your fix.