Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbcDFQe3 (ORCPT ); Wed, 6 Apr 2016 12:34:29 -0400 Received: from mail-by2on0120.outbound.protection.outlook.com ([207.46.100.120]:3143 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750973AbcDFQe1 convert rfc822-to-8bit (ORCPT ); Wed, 6 Apr 2016 12:34:27 -0400 From: Hartley Sweeten To: Ian Abbott , Sudip Mukherjee , Greg Kroah-Hartman CC: "linux-kernel@vger.kernel.org" , "devel@driverdev.osuosl.org" Subject: RE: [PATCH] staging: comedi: das1800: remove unused variable Thread-Topic: [PATCH] staging: comedi: das1800: remove unused variable Thread-Index: AQHRj0ayv1HPe+Sq10ymMrFhplG7AZ98JfPwgACMW4CAAG58YA== Date: Wed, 6 Apr 2016 16:19:20 +0000 Message-ID: References: <1459866185-1722-1-git-send-email-sudipm.mukherjee@gmail.com> <5704D9AD.4050807@mev.co.uk> In-Reply-To: <5704D9AD.4050807@mev.co.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mev.co.uk; dkim=none (message not signed) header.d=none;mev.co.uk; dmarc=none action=none header.from=visionengravers.com; x-originating-ip: [184.183.19.121] x-ms-office365-filtering-correlation-id: dcd82e60-e326-4f7e-122c-08d35e373592 x-microsoft-exchange-diagnostics: 1;BN3PR0101MB1057;5:CHd6v0pZsHsFHxHNJ5YCzC6IhwJ2ANMyPptzHYD+8F57MR2Xxl8937IUR41JHvCamI+1CoVDv/rerWDkQEVzg3TLlgSFc95eWambXxdh2buy492ennpqiQ2B1G+6LzZ1w7KVB20BEYgZ4WV9chKkiw==;24:4w2KLbKM/J60R4YQ+M9GlM07HZPruZnAwj3yMt6SuQvEajUTJpK+2WAaNgVm6SK1sVST2zBtZDSeGWHM5R5Y0HrUt7T82oXCQMBf+nCsZNo= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1057; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040074)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041046)(6043046);SRVR:BN3PR0101MB1057;BCL:0;PCL:0;RULEID:;SRVR:BN3PR0101MB1057; x-forefront-prvs: 0904004ECB x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377454003)(24454002)(76176999)(54356999)(122556002)(50986999)(2950100001)(5002640100001)(80792005)(92566002)(2900100001)(77096005)(87936001)(74316001)(66066001)(81166005)(86362001)(10400500002)(5008740100001)(5001770100001)(33656002)(11100500001)(106116001)(164054004)(5004730100002)(586003)(1096002)(1220700001)(6116002)(102836003)(19580405001)(19580395003)(5003600100002)(2906002)(4326007)(3280700002)(3660700001)(189998001)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR0101MB1057;H:BN3PR0101MB1057.prod.exchangelabs.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visionengravers.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2016 16:19:20.1693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d698601f-af92-4269-8099-fd6f11636477 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0101MB1057 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 831 Lines: 25 On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukherjee >>> --- >>> >>> There may be a chance that reading from DAS1800_CONTROL_C is necessary >>> before reading from DAS1800_STATUS. If that is true then please discard >>> this patch. >> >> Actually the driver has a bug here. >> >> The analog input samples should be munged if the inputs are configured for >> bipolar mode. >> >> I have a series almost ready that cleans up this driver and fixes the bug. > > Hi Hartley, can the bug fix be placed at the top of your patch series? I'll split it out as a separate patch and post it shortly. Thanks, Hartley