Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663AbcDFRXW (ORCPT ); Wed, 6 Apr 2016 13:23:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56168 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbcDFRXU (ORCPT ); Wed, 6 Apr 2016 13:23:20 -0400 Date: Wed, 6 Apr 2016 13:23:14 -0400 From: Jessica Yu To: Miroslav Benes Cc: Josh Poimboeuf , Jiri Kosina , Chris J Arges , eugene.shatokhin@rosalab.ru, live-patching@vger.kernel.org, Linux Kernel Mailing List , pmladek@suse.cz Subject: Re: Bug with paravirt ops and livepatches Message-ID: <20160406172313.GB19648@packer-debian-8-amd64.digitalocean.com> References: <20160401190704.GB7837@canonical.com> <20160404161428.3qap2i4vpgda66iw@treble.redhat.com> <20160405191907.GC10567@packer-debian-8-amd64.digitalocean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-OS: Linux eisen.io 3.16.0-4-amd64 x86_64 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 24 +++ Miroslav Benes [06/04/16 10:43 +0200]: >On Wed, 6 Apr 2016, Miroslav Benes wrote: > >> Anyway I see there are some new comments on github. I'll look at those. >> But I'd prefer to discuss all the relevant things (that is kpatch >> unspecific) here. It would make it easier. > >And you do (after seeing dates of the posts there), sorry for the noise. > >Jessica, I think I am perfectly fine with introducing some arch-specific >code because of this problem. > >We used generic apply_relocate_add() because it was a single >arch-independent entry point. There is no such things for paravirt_ops, >alternatives, jump labels and such things. In fact only module_finalize() >is there and that is not enough. So some arch-specific code in livepatch >seems to be unnecessary. > Yeah, unfortunately that appears to be the case..Luckily I don't think we need to add much code; the calls should be similar to the way we call apply_relocate_add(), just pass in the right sections. Jessica