Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752590AbcDFRkt (ORCPT ); Wed, 6 Apr 2016 13:40:49 -0400 Received: from foss.arm.com ([217.140.101.70]:58570 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751873AbcDFRkr (ORCPT ); Wed, 6 Apr 2016 13:40:47 -0400 Subject: Re: [PATCH v5 4/9] irqchip/gic-v2: Parse and export virtual GIC information To: Christoffer Dall References: <1459769860-6629-1-git-send-email-julien.grall@arm.com> <1459769860-6629-5-git-send-email-julien.grall@arm.com> <20160406170432.GD8961@cbox> Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, fu.wei@linaro.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wei@redhat.com, al.stone@linaro.org, gg@slimlogic.co.uk, Thomas Gleixner , Jason Cooper From: Julien Grall Message-ID: <57054A19.1090208@arm.com> Date: Wed, 6 Apr 2016 18:40:41 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160406170432.GD8961@cbox> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 669 Lines: 23 Hi Christoffer, On 06/04/2016 18:04, Christoffer Dall wrote: > On Mon, Apr 04, 2016 at 12:37:35PM +0100, Julien Grall wrote: >> diff --git a/include/linux/irqchip/arm-gic-common.h b/include/linux/irqchip/arm-gic-common.h >> new file mode 100644 >> index 0000000..ef34f6f >> --- /dev/null >> +++ b/include/linux/irqchip/arm-gic-common.h > > just out of curiosity, why is include/linux/irqchip/arm-gic.h not > suitable? Because arm-gic.h contains the definitions for GICv2 only. At least one of them is clashing with the GICv3 ones. For instance, the function gic_send_sgi is defined statically the in GICv3 code, but exported for GICv2. Regards, -- Julien Grall