Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752646AbcDFRpc (ORCPT ); Wed, 6 Apr 2016 13:45:32 -0400 Received: from foss.arm.com ([217.140.101.70]:58597 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752498AbcDFRpa (ORCPT ); Wed, 6 Apr 2016 13:45:30 -0400 Subject: Re: [PATCH v5 6/9] irqchip/gic-v3: Parse and export virtual GIC information To: Christoffer Dall References: <1459769860-6629-1-git-send-email-julien.grall@arm.com> <1459769860-6629-7-git-send-email-julien.grall@arm.com> <20160406172228.GE8961@cbox> Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, fu.wei@linaro.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wei@redhat.com, al.stone@linaro.org, gg@slimlogic.co.uk, Thomas Gleixner , Jason Cooper From: Julien Grall Message-ID: <57054B2F.8040907@arm.com> Date: Wed, 6 Apr 2016 18:45:19 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160406172228.GE8961@cbox> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 687 Lines: 28 Hi Christoffer, On 06/04/2016 18:22, Christoffer Dall wrote: > On Mon, Apr 04, 2016 at 12:37:37PM +0100, Julien Grall wrote: >> +static void __init gic_acpi_setup_kvm_info(void) >> +{ >> + int irq; >> + >> + if (!gic_acpi_collect_virt_info()) { >> + pr_warn("Unable to get hardware information used for virtualization\n"); > > perhaps this should say something about gicv3 as well? Actually, none of the pr_* call contain GICv3 and there is no pr_fmt. I'm thinking to send a patch to add pr_fmt in the GICv3 driver. > > Otherwise (with my extremely limited acpi understanding): > > Reviewed-by: Christoffer Dall Thank you! Regards, -- Julien Grall