Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752942AbcDFTAz (ORCPT ); Wed, 6 Apr 2016 15:00:55 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34474 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848AbcDFTAx (ORCPT ); Wed, 6 Apr 2016 15:00:53 -0400 Date: Wed, 6 Apr 2016 12:00:48 -0700 From: Daniel Lezcano To: Dave Gerlach Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "Rafael J . Wysocki" Subject: Re: [PATCH] cpuidle: Indicate when a device has been unregistered Message-ID: <20160406190047.GA32535@linaro.org> References: <1459883138-21136-1-git-send-email-d-gerlach@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459883138-21136-1-git-send-email-d-gerlach@ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 785 Lines: 16 On Tue, Apr 05, 2016 at 02:05:38PM -0500, Dave Gerlach wrote: > Currently the 'registered' member of the cpuidle_device struct is set > to 1 during cpuidle_register_device. In this same function there are > checks to see if the device is already registered to prevent duplicate > calls to register the device, but this value is never set to 0 even on > unregister of the device. Because of this, any attempt to call > cpuidle_register_device after a call to cpuidle_unregister_device will > fail which shouldn't be the case. > > To prevent this, set registered to 0 when the device is unregistered. > > Fixes: c878a52d3c7c ("cpuidle: Check if device is already registered") > Signed-off-by: Dave Gerlach > --- Acked-by: Daniel Lezcano