Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753426AbcDFU2O (ORCPT ); Wed, 6 Apr 2016 16:28:14 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:32931 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbcDFU2M (ORCPT ); Wed, 6 Apr 2016 16:28:12 -0400 MIME-Version: 1.0 In-Reply-To: <1459958105-1090-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1459958105-1090-1-git-send-email-vivien.didelot@savoirfairelinux.com> From: Florian Fainelli Date: Wed, 6 Apr 2016 13:27:32 -0700 Message-ID: Subject: Re: [PATCH net-next v2 0/3] net: dsa: voidify STP setter and FDB/VLAN add ops To: Vivien Didelot Cc: netdev , "linux-kernel@vger.kernel.org" , kernel , "David S. Miller" , Andrew Lunn , Jiri Pirko , Scott Feldman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 815 Lines: 21 2016-04-06 8:55 GMT-07:00 Vivien Didelot : > Neither the DSA layer nor the bridge code (see br_set_state) really care > about eventual errors from STP state setters, so make it void. > > The DSA layer separates the prepare and commit phases of switchdev in > two different functions. Logical errors must not happen in commit > routines, so make them void. > > Changes v1 -> v2: > - rename port_stp_update to port_stp_state_set > - don't change code flow of bcm_sf2_sw_br_set_stp_state > - prefer netdev_err over netdev_warn > > Vivien Didelot (3): > net: dsa: make the STP state function return void > net: dsa: make the FDB add function return void > net: dsa: make the VLAN add function return void Reviewed-by: Florian Fainelli -- Florian