Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753739AbcDFV1o (ORCPT ); Wed, 6 Apr 2016 17:27:44 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:37362 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752127AbcDFV1m (ORCPT ); Wed, 6 Apr 2016 17:27:42 -0400 MIME-Version: 1.0 In-Reply-To: References: <1459947782-5071-1-git-send-email-ed@abdsec.com> Date: Wed, 6 Apr 2016 14:27:38 -0700 X-Google-Sender-Auth: hZKzaa79fL7LxU3dWp0__CkGYKM Message-ID: Subject: Re: [PATCH] KERNEL: resource: Fix bug on leakage in /proc/iomem file From: Kees Cook To: Linus Torvalds Cc: Emrah Demir , Linux Kernel Mailing List , Dan Rosenberg , "kernel-hardening@lists.openwall.com" , Dave Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 776 Lines: 22 On Wed, Apr 6, 2016 at 2:19 PM, Linus Torvalds wrote: > On Wed, Apr 6, 2016 at 10:54 AM, Linus Torvalds > wrote: >> >> So I'd find a patch like the attached to be perfectly acceptable (in >> fact, we should have done this long ago). > > I just committed it, let's see if some odd program uses the iomem > data. I doubt it, and I always enjoy improvements that remove more > lines of code than they add. Hrm, okay. I still think just changing the perms would be less troublesome. Knowing where the kernel is in physical memory when debugging physical memory issues seems important to me. But, I have never actually used it since I prefer looking in kallsyms. :) -Kees -- Kees Cook Chrome OS & Brillo Security