Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754498AbcDFWOI (ORCPT ); Wed, 6 Apr 2016 18:14:08 -0400 Received: from mga11.intel.com ([192.55.52.93]:5879 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753521AbcDFWOF (ORCPT ); Wed, 6 Apr 2016 18:14:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; d="scan'208";a="927017843" From: "Koul, Vinod" To: "lars@metafoo.de" , "appana.durga.rao@xilinx.com" , "sorenb@xilinx.com" CC: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "anirudh@xilinx.com" , "luis@debethencourt.com" , "moritz.fischer@ettus.com" , "michals@xilinx.com" , "svemula@xilinx.com" , "devicetree@vger.kernel.org" , "Williams, Dan J" , "mark.rutland@arm.com" , "galak@codeaurora.org" , "ijc+devicetree@hellion.org.uk" , "dmaengine@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "laurent.pinchart@ideasonboard.com" Subject: Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Thread-Topic: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan Thread-Index: AQHRkB+tMNON9LaHQ029m8TpSbwCX598w/wAgAABkQCAAFEWgIAAECaA Date: Wed, 6 Apr 2016 22:13:59 +0000 Message-ID: <1459980839.3136.87.camel@intel.com> References: <1459959335-24083-1-git-send-email-appanad@xilinx.com> <1459959335-24083-2-git-send-email-appanad@xilinx.com> <20160406162022.GS23198@xsjsorenbubuntu> <57057C9B.8040804@metafoo.de> In-Reply-To: <57057C9B.8040804@metafoo.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.180.190] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u36MEE9b005688 Content-Length: 1601 Lines: 43 On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > +++ > > > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > @@ -24,8 +24,8 @@ Optional properties: > > > > {3}, flush s2mm channel > > > > > > > > Required child node properties: > > > > -- compatible: It should be either "xlnx,axi-vdma-mm2s-channel" > > > > or > > > > - "xlnx,axi-vdma-s2mm-channel". > > > > +- compatible: It should be either "xlnx,axi-dma-mm2s-channel" > > > > or > > > > + "xlnx,axi-dma-s2mm-channel". > > > > > > This change is not backwards compatible and breaks every user of > > > the current > > > binding. > > > > This commit http://git.kernel.org/cgit/linux/kernel/git/vkoul/slave- > > dma.git/commit/?h=next&id=8e66e7d682b04f7141f8ae666908c8dcd7fc0bfa > > Renames xilinx_vdma_ prefix to xilinx_dma which includes renaming of > > the above properties. That patch changes driver from vdma to dma. It does not change property name! > > The patch (dmaengine: vdma: Rename xilinx_vdma_ prefix to > > xilinx_dma) already got applied in the dma-next tree. > > That's why sent this patch to sync with the current driver I mean > > latest driver. > > The correct solution for this is to revert that part of the change > ASAP, > since, as Soeren pointed out, it breaks all existing users. No the commit applied is only the name changes inside the driver. They don't break anything yet. IIUC this patch breaks not the applied one.. Thanks -- ~Vinod