Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750990AbcDGEHK (ORCPT ); Thu, 7 Apr 2016 00:07:10 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:33525 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbcDGEHI (ORCPT ); Thu, 7 Apr 2016 00:07:08 -0400 MIME-Version: 1.0 In-Reply-To: <20160405130223.GC32576@infradead.org> References: <1459857443-20611-1-git-send-email-tom.leiming@gmail.com> <1459857443-20611-10-git-send-email-tom.leiming@gmail.com> <20160405130223.GC32576@infradead.org> Date: Thu, 7 Apr 2016 12:07:07 +0800 Message-ID: Subject: Re: [PATCH 09/27] target: use bio_is_full() From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Linux Kernel Mailing List , linux-block@vger.kernel.org, Boaz Harrosh , "Nicholas A. Bellinger" , "open list:TARGET SUBSYSTEM" , "open list:TARGET SUBSYSTEM" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 848 Lines: 21 On Tue, Apr 5, 2016 at 9:02 PM, Christoph Hellwig wrote: > On Tue, Apr 05, 2016 at 07:56:54PM +0800, Ming Lei wrote: >> +++ b/drivers/target/target_core_pscsi.c >> @@ -951,7 +951,7 @@ pscsi_map_sg(struct se_cmd *cmd, struct scatterlist *sgl, u32 sgl_nents, >> pr_debug("PSCSI: bio->bi_vcnt: %d nr_vecs: %d\n", >> bio->bi_vcnt, nr_vecs); >> >> - if (bio->bi_vcnt > nr_vecs) { >> + if (bio_is_full(bio)) { >> pr_debug("PSCSI: Reached bio->bi_vcnt max:" >> " %d i: %d bio: %p, allocating another" >> " bio\n", bio->bi_vcnt, i, bio); > > This check should be removed entirely - bio_add_pc_page takes care of > it. OK. -- Ming Lei