Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753886AbcDGFHX (ORCPT ); Thu, 7 Apr 2016 01:07:23 -0400 Received: from mga09.intel.com ([134.134.136.24]:24540 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbcDGFHW (ORCPT ); Thu, 7 Apr 2016 01:07:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; d="asc'?scan'208";a="80630069" From: Felipe Balbi To: changbin.du@intel.com Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Du\, Changbin" Subject: Re: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs In-Reply-To: <1459957446-6854-1-git-send-email-changbin.du@intel.com> References: <20160406092509.GA29930@kroah.com> <1459957446-6854-1-git-send-email-changbin.du@intel.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Thu, 07 Apr 2016 08:05:22 +0300 Message-ID: <87zit6ypnx.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 52 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, before I review your patches, one comment changbin.du@intel.com writes: > From: "Du, Changbin" > > The first patch removed unnecessary checking for debugfs api call; > The second patch fix a memory leak issue; > The third patch add one new entry to debufs. > > Du, Changbin (3): > usb: dwc3: make dwc3_debugfs_init return value be void this is _not_ a fix > usb: dwc3: free dwc->regset on dwc3_debugfs_exit but this is. Why isn't this, at least, the first patch in the list ? In fact, it would be preferred that this patch be sent by itself and the following two patches should be on another branch completely without any dependencies to the memory leak fix. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXBeqTAAoJEIaOsuA1yqREdeIP/RYtqEZaz0DhpA2/Gp2CIFga Gfp0yuNF+4HtsZwn7E2y7kmbmYy2VvdRr42fYZtEm1BCVmkigludtzT833ovWRgR UE5nHVsE9LjjaAESN76X35+Puz/E77C8xeCJSG3gHjXw5QBzIeVsVUMM8Ph1Ctm5 453uiG7ztj5lDXsJKn9I0CWptUogGjGV7uKw0jdLtKIYGLRsVsWVTFP1ExftouQ1 y5Lr7nG9VWQlfEkJy2WcJMSXfkzfCYzpsgEuGlYbIOx0V+e1ZFPQuk5+QAhVN8hM xX7KW0kgxcqyNdFXo80xXPL6eE1rFl9I5Y2Ay4PBERSo418aE3aKltM65TpdjhHV qeUrHTPzVLu7kxfP5tLJHDLE9Gf2DVXP4I5dV0Kp6bgaManLJsPmCChL2gRHsQ1c 6M8OkOHvIL0iPOrrF3FQHAOXZ0qKMJlEVePM1uDJUtydO9X99LgCYveRdTQsZO8a svm4HIk/7d8FXgQlxXyZQUxcr+MnVJhkR2eIDtFosil7gCdvhcupBtKJhdL8Bxu1 rv3shENSJUFcnEy1rC8OIGAhLZbDIkyr+/QXPjpz4cY9tNLgDX9YR90Mi4+Habpq uH04688vx82GLYwjEKOPAlq9s0zEM+5WmBSS07sSnhYfuePoB8nZMFy5kILVLBYS vMH5DCsV/8onlrenwtMl =gqZP -----END PGP SIGNATURE----- --=-=-=--