From: "Du, Changbin" <changbin.du@intel.com>
To: Felipe Balbi <balbi@kernel.org>
CC: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs
Thread-Topic: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs
Thread-Index: AQHRkByrEzLWpIhidUu+c+OuQAZqjZ99b9cAgACJnhA=
Date: Thu, 7 Apr 2016 05:21:17 +0000
Message-ID: <0C18FE92A7765D4EB9EE5D38D86A563A05CEBDCF@shsmsx102.ccr.corp.intel.com>
References: <20160406092509.GA29930@kroah.com>
 <1459957446-6854-1-git-send-email-changbin.du@intel.com>
 <87zit6ypnx.fsf@intel.com>
In-Reply-To: <87zit6ypnx.fsf@intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 923
Lines: 29

> before I review your patches, one comment
> 
> changbin.du@intel.com writes:
> > From: "Du, Changbin" <changbin.du@intel.com>
> >
> > The first patch removed unnecessary checking for debugfs api call;
> > The second patch fix a memory leak issue;
> > The third patch add one new entry to debufs.
> >
> > Du, Changbin (3):
> >   usb: dwc3: make dwc3_debugfs_init return value be void
> 
> this is _not_ a fix
> 
> >   usb: dwc3: free dwc->regset on dwc3_debugfs_exit
> 
> but this is. Why isn't this, at least, the first patch in the list ? In
> fact, it would be preferred that this patch be sent by itself and the
> following two patches should be on another branch completely without any
> dependencies to the memory leak fix.
> 
> --
> Balbi

Sure, Balbi. This will be better. I will send out patch v3 and another independent
patch. Also include changelog as Greg required. Thanks for checking.

Regards,
Du, Changbin