Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751841AbcDGFY3 (ORCPT ); Thu, 7 Apr 2016 01:24:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:19432 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbcDGFY2 (ORCPT ); Thu, 7 Apr 2016 01:24:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,448,1455004800"; d="asc'?scan'208";a="779790551" From: Felipe Balbi To: "Du\, Changbin" Cc: "gregkh\@linuxfoundation.org" , "linux-usb\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A05CEBDCF@shsmsx102.ccr.corp.intel.com> References: <20160406092509.GA29930@kroah.com> <1459957446-6854-1-git-send-email-changbin.du@intel.com> <87zit6ypnx.fsf@intel.com> <0C18FE92A7765D4EB9EE5D38D86A563A05CEBDCF@shsmsx102.ccr.corp.intel.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Thu, 07 Apr 2016 08:22:27 +0300 Message-ID: <87oa9myovg.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2095 Lines: 63 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable HI "Du, Changbin" writes: >> before I review your patches, one comment >>=20 >> changbin.du@intel.com writes: >> > From: "Du, Changbin" >> > >> > The first patch removed unnecessary checking for debugfs api call; >> > The second patch fix a memory leak issue; >> > The third patch add one new entry to debufs. >> > >> > Du, Changbin (3): >> > usb: dwc3: make dwc3_debugfs_init return value be void >>=20 >> this is _not_ a fix >>=20 >> > usb: dwc3: free dwc->regset on dwc3_debugfs_exit >>=20 >> but this is. Why isn't this, at least, the first patch in the list ? In >> fact, it would be preferred that this patch be sent by itself and the >> following two patches should be on another branch completely without any >> dependencies to the memory leak fix. >>=20 >> -- >> Balbi > > Sure, Balbi. This will be better. I will send out patch v3 and another in= dependent > patch. Also include changelog as Greg required. Thanks for checking. thanks, that way we can get the fix during the -rc cycle and the other two patches on next merge window ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXBe6TAAoJEIaOsuA1yqRE1/gP/iBex8Sfux77T2/fX1tMuFYb O7BTp48MdJAAIXwqRkwdlmi334ukfZtQMvzBdgEJvsJD8+ztdw4eZHICZihwDLYM IBxkddjgviFXzfEtVZnLCfcPQ+f9daKlo3nBGGrehec7ZKA7Aiee9m7CmMmGED7H GX+sU9tgU9Lmq7SU2ybZx23JbAhg6s4HKYXRpTG63xYrdp0LGf+zGGcEvmk6plLs tSJrze5DnArrlgBLiYdNoQge7HZ/MlRiH4rDkXQh3fS8Dn5TTPwXGFcxRvOp1yqz odoyNOXlarmy6X7TKXVJp7FH6uUcP82K0gi944KgmRSNu+zLSYobD9DqTdcX3TGu lpd/plclfOm21SqU06rCXZB03IV5tLUN5UGEl8/yEJDWunFcgIQNJGOSEJ+JS08w NZNDFDcWTBk0d7Qax5DMpohabLk3zFMeHaO4nUayPGRu5VtYc4uH8PqqVbP2ErBX 1nAFauhKmZtPbUh65QUin1jnK5XRXKJOW3XNl8sbixPAJJJbICBdIli83i10GcGP MfbPEmBUkpTQo+Mv0CRjy5jV7xcKli6/6oRSjGSAA3NYYgggdf7fNmn6Rywz4POW B5y7FkHHItCljtBd3sUtzTlDsDWUPN6m6laCdcl7/0OsJiCPJRcz4H/8GH+oH4mr +w9Mckxyma4fInsvnhvB =v3aU -----END PGP SIGNATURE----- --=-=-=--