Message-ID: <1460016350.6715.73.camel@perches.com>
Subject: Re: [PATCH v3 1/6] string_helpers: add kstrdup_quotable
From: Joe Perches <joe@perches.com>
To: Kees Cook <keescook@chromium.org>, James Morris <jmorris@namei.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
        Guenter Roeck <linux@roeck-us.net>, Jiri Slaby <jslaby@suse.com>,
        Paul Moore <pmoore@redhat.com>, Stephen Smalley <sds@tycho.nsa.gov>,
        Casey Schaufler <casey@schaufler-ca.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Thu, 07 Apr 2016 01:05:50 -0700
In-Reply-To: <1459988437-3429-2-git-send-email-keescook@chromium.org>
References: <1459988437-3429-1-git-send-email-keescook@chromium.org>
	 <1459988437-3429-2-git-send-email-keescook@chromium.org>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 488
Lines: 14

On Wed, 2016-04-06 at 17:20 -0700, Kees Cook wrote:
> Handle allocating and escaping a string safe for logging.

trivia: should add const

> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
[]
> @@ -68,4 +68,6 @@ static inline int string_escape_str_any_np(const char *src, char *dst,
> ?	return string_escape_str(src, dst, sz, ESCAPE_ANY_NP, only);
> ?}
> ?
> +char *kstrdup_quotable(char *src, gfp_t gfp);

char *kstrdup_quotable(const char *src, gfp_t gfp);