Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755677AbcDGJqQ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Apr 2016 05:46:16 -0400
Received: from smtp.citrix.com ([66.165.176.89]:56732 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751346AbcDGJqP (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Apr 2016 05:46:15 -0400
X-IronPort-AV: E=Sophos;i="5.24,449,1454976000"; 
   d="scan'208";a="345470377"
Subject: Re: [Xen-devel] [PATCH v4 11/14] pnpbios: replace paravirt_enabled()
 check with legacy device check
To: "Luis R. Rodriguez" <mcgrof@kernel.org>, <bp@alien8.de>, <hpa@zytor.com>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <rusty@rustcorp.com.au>
References: <1459987594-5434-1-git-send-email-mcgrof@kernel.org>
 <1459987594-5434-12-git-send-email-mcgrof@kernel.org>
CC: <xen-devel@lists.xensource.com>, <matt@codeblueprint.co.uk>,
        <andrew.cooper3@citrix.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <luto@amacapital.net>, <jlee@suse.com>,
        <lguest@lists.ozlabs.org>, <glin@suse.com>, <david.vrabel@citrix.com>,
        <boris.ostrovsky@oracle.com>, <andriy.shevchenko@linux.intel.com>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <57062C63.2010609@citrix.com>
Date: Thu, 7 Apr 2016 10:46:11 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1459987594-5434-12-git-send-email-mcgrof@kernel.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 692
Lines: 19

On 07/04/16 01:06, Luis R. Rodriguez wrote:
> Since we are removing paravirt_enabled() replace it with a
> logical equivalent. Even though PNPBIOS is x86 specific we
> add an arch-specific type call, which can be implemented by
> any architecture to show how other legacy attribute devices
> can later be also checked for with other ACPI legacy attribute
> flags.
> 
> This implicates the first ACPI 5.2.9.3 IA-PC Boot Architecture
> ACPI_FADT_LEGACY_DEVICES flag device, and shows how to add more.
[...]
> +struct x86_legacy_devices {
> +	int pnpbios;
> +};

It's not clear why pnpbios needs a new structure and why this structure
of devices does not have the bit for the rtc device.

David