Message-ID: <57063E91.1070202@linux.intel.com>
Date: Thu, 07 Apr 2016 14:03:45 +0300
From: Mathias Nyman <mathias.nyman@linux.intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Thierry Reding <thierry.reding@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mathias Nyman <mathias.nyman@intel.com>
CC: Stephen Warren <swarren@wwwdotorg.org>,
        Alexandre Courbot <gnurou@gmail.com>,
        Andrew Bresticker <abrestic@chromium.org>, linux-tegra@vger.kernel.org,
        devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 8/9] usb: xhci: Add NVIDIA Tegra XUSB controller driver
References: <1457108379-20794-1-git-send-email-thierry.reding@gmail.com> <1457108379-20794-8-git-send-email-thierry.reding@gmail.com>
In-Reply-To: <1457108379-20794-8-git-send-email-thierry.reding@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1479
Lines: 46

On 04.03.2016 18:19, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Add support for the on-chip XUSB controller present on Tegra SoCs. This
> controller, when loaded with external firmware, exposes an interface
> compliant with xHCI. This driver loads the firmware, starts the
> controller, and is able to service host-specific messages sent by the
> controller's firmware.
>
> The controller also supports USB device mode as well as powergating
> of the SuperSpeed and host-controller logic when not in use, but
> support for these is not yet implemented.
>
> Based on work by:
>    Ajay Gupta <ajayg@nvidia.com>
>    Bharath Yadav <byadav@nvidia.com>
>    Andrew Bresticker <abrestic@chromium.org>
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Mathias Nyman <mathias.nyman@intel.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---

...

> +static int tegra_xusb_remove(struct platform_device *pdev)
> +{
> +	struct tegra_xusb *tegra = platform_get_drvdata(pdev);
  > +	struct usb_hcd *hcd = tegra->hcd;
> +	struct xhci_hcd *xhci;
> +
> +	if (tegra->fw_loaded) {
> +		xhci = hcd_to_xhci(hcd);
> +		usb_remove_hcd(xhci->shared_hcd);
> +		usb_put_hcd(xhci->shared_hcd);
> +		usb_remove_hcd(hcd);
> +		tegra_xusb_padctl_put(tegra->padctl);
> +		usb_put_hcd(hcd);
> +		kfree(xhci);

Don't free xhci here, xhci is a part of hcd (hcd_priv) and hcd is already freed in usb_put_hcd()

Other than that I can't see any issues

-Mathias