Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756188AbcDGMj3 (ORCPT ); Thu, 7 Apr 2016 08:39:29 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54544 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755419AbcDGMj1 (ORCPT ); Thu, 7 Apr 2016 08:39:27 -0400 Subject: Re: [PATCH 1/4] mailbox/omap: store mailbox interrupt type in omap_mbox_device To: Suman Anna , Jassi Brar References: <1459985840-1106-1-git-send-email-s-anna@ti.com> <1459985840-1106-2-git-send-email-s-anna@ti.com> <57063731.9010201@ti.com> <57065190.4050904@ti.com> CC: , , From: Grygorii Strashko Message-ID: <570654E6.20908@ti.com> Date: Thu, 7 Apr 2016 15:39:02 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <57065190.4050904@ti.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2015 Lines: 56 On 04/07/2016 03:24 PM, Suman Anna wrote: > Hi Grygorii, > > On 04/07/2016 05:32 AM, Grygorii Strashko wrote: >> On 04/07/2016 02:37 AM, Suman Anna wrote: >>> The interrupt type used for identifying the layout of the interrupt >>> configuration registers between OMAP4+ SoCs and older SoCs is stored >>> only in the sub-mailbox structures for easier access. Store this type >>> in the the omap_mbox_device structure as well along with the other >>> global variables. This is being done to facilitate the context save >>> and restore of appropriate registers during system suspend/resume. >>> >>> Signed-off-by: Suman Anna >>> --- >>> drivers/mailbox/omap-mailbox.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/mailbox/omap-mailbox.c >>> b/drivers/mailbox/omap-mailbox.c >>> index 84cafc02e761..adf37f494690 100644 >>> --- a/drivers/mailbox/omap-mailbox.c >>> +++ b/drivers/mailbox/omap-mailbox.c >>> @@ -90,6 +90,7 @@ struct omap_mbox_device { >>> void __iomem *mbox_base; >>> u32 num_users; >>> u32 num_fifos; >>> + u32 intr_type; >>> struct omap_mbox **mboxes; >>> struct mbox_controller controller; >>> struct list_head elem; >>> @@ -828,6 +829,7 @@ static int omap_mbox_probe(struct platform_device >>> *pdev) >>> mdev->dev = &pdev->dev; >>> mdev->num_users = num_users; >>> mdev->num_fifos = num_fifos; >>> + mdev->intr_type = intr_type; >>> mdev->mboxes = list; >>> >>> /* OMAP does not have a Tx-Done IRQ, but rather a Tx-Ready IRQ */ >>> >> >> This smth. which definitely has to be done using compatible props. >> Why not to pass more info through of_device_id->data? >> > > Yeah, that's already the case, intr_type is a local variable assigned > from compatible match data. This patch merely caches it in the > omap_mbox_device structure so that it can be leveraged by the PM > callback functions in the next patch. > Ah ok. Thanks for explanation. -- regards, -grygorii