Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756205AbcDGMzS (ORCPT ); Thu, 7 Apr 2016 08:55:18 -0400 Received: from exsmtp01.microchip.com ([198.175.253.37]:56060 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753684AbcDGMzQ (ORCPT ); Thu, 7 Apr 2016 08:55:16 -0400 Subject: Re: [PATCH v2 2/2] usb: musb: pic32: Add USB DRC driver for PIC32 OTG controller. To: Felipe Balbi , References: <460027775-20729-2-git-send-email-purna.mandal@microchip.com> <1460032381-32677-1-git-send-email-purna.mandal@microchip.com> <1460032381-32677-2-git-send-email-purna.mandal@microchip.com> <874mbdr3s2.fsf@intel.com> CC: Rob Herring , , Joshua Henderson , Cristian Birsan , Greg Kroah-Hartman , Bin Liu , Kumar Gala From: Purna Chandra Mandal Message-ID: <57065847.3030105@microchip.com> Date: Thu, 7 Apr 2016 18:23:27 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <874mbdr3s2.fsf@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1688 Lines: 50 On 04/07/2016 06:09 PM, Felipe Balbi wrote: > Purna Chandra Mandal writes: >> From: Cristian Birsan >> >> This driver adds support of PIC32 MUSB OTG controller as >> dual role device. It implements platform specific glue to >> reuse musb core. >> >> Signed-off-by: Cristian Birsan >> Signed-off-by: Purna Chandra Mandal >> >> In-reply-to: 460027775-20729-2-git-send-email-purna.mandal@microchip.com >> >> --- >> >> Changes in v2: >> - fix i386 build >> - fix indentation >> >> drivers/usb/musb/Kconfig | 9 +- >> drivers/usb/musb/Makefile | 1 + >> drivers/usb/musb/pic32.c | 608 ++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 617 insertions(+), 1 deletion(-) >> create mode 100644 drivers/usb/musb/pic32.c >> >> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >> index 886526b..1970c1e 100644 >> --- a/drivers/usb/musb/Kconfig >> +++ b/drivers/usb/musb/Kconfig >> @@ -112,6 +112,13 @@ config USB_MUSB_BLACKFIN >> depends on (BF54x && !BF544) || (BF52x && ! BF522 && !BF523) >> depends on NOP_USB_XCEIV >> >> +config USB_MUSB_PIC32 >> + tristate "Microchip PIC32 USB platforms" >> + depends on MACH_PIC32 > no, we like to build stuff on other arches, this should be: > > depends on MACH_PIC32 || COMPILE_TEST > > and you should *really* fix the build error, not work around it. This driver is for PIC32MZDA platforms which are powered by MIPS 14Kec CPU. The offending API 'readsl()' is implemented by MIPS arch (in arch/mips/include/asm/io.h), but not by i386 arch. IMO compiling for i386 is not required.