Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756397AbcDGNiI (ORCPT ); Thu, 7 Apr 2016 09:38:08 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:32967 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753592AbcDGNiG (ORCPT ); Thu, 7 Apr 2016 09:38:06 -0400 Subject: Re: [PATCH v1 1/2] dt/bindings/usb: Add bindings for PIC32 MUSB driver. To: Purna Chandra Mandal , linux-kernel@vger.kernel.org References: <1460027775-20729-1-git-send-email-purna.mandal@microchip.com> <57065841.9020105@cogentembedded.com> <57065A4A.8090203@microchip.com> <57065CB4.5080108@cogentembedded.com> <57065F7F.6030902@microchip.com> Cc: Rob Herring , linux-usb@vger.kernel.org, Joshua Henderson , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , Pawel Moll , Mark Rutland From: Sergei Shtylyov Message-ID: <570662BA.5070207@cogentembedded.com> Date: Thu, 7 Apr 2016 16:38:02 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <57065F7F.6030902@microchip.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3077 Lines: 72 On 4/7/2016 4:24 PM, Purna Chandra Mandal wrote: >>>>> Document devicetree binding for the USB controller >>>> >>>> Device tree. >>>> >>> ack. >>> >>>>> and USB Phy found on Microchip PIC32 class devices. >>>> >>>> PHY. >>>> >>> ack. >>> >>>>> Signed-off-by: Purna Chandra Mandal >>>>> >>>>> --- >>>>> >>>>> .../bindings/usb/microchip,pic32-musb.txt | 67 ++++++++++++++++++++++ >>>>> 1 file changed, 67 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/usb/microchip,pic32-musb.txt >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/usb/microchip,pic32-musb.txt b/Documentation/devicetree/bindings/usb/microchip,pic32-musb.txt >>>>> new file mode 100644 >>>>> index 0000000..e1cec9d >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/usb/microchip,pic32-musb.txt >>>>> @@ -0,0 +1,67 @@ >>>>> +Microchip PIC32 MUSB DRC/OTG controller >>>>> +------------------------------------------- >>>>> + >>>>> +Required properties: >>>>> + - compatible : should be "microchip,pic32mzda-usb". >>>>> + - reg : offset and length of "MUSB Core Registers" and >>>>> + "USB Clock & Reset Registers". >>>>> + - reg-names : should be "mc", and "usbcr" in order >>>>> + - clocks : clock specifier for the musb controller clock >>>>> + - clock-names : should be "usb_clk" >>>>> + - interrupts : interrupt number for MUSB Core General interrupt >>>>> + and DMA interrupt >>>>> + - interrupt-names : must be "mc" and "dma" in order. >>>>> + - phys : phy specifier for the otg phy. >>>>> + - dr_mode : should be one of "host", "peripheral" or "otg". >>>>> + - mentor,multipoint: Should be "1" indicating the musb controller supports >>>>> + multipoint. This is MUSB configuration-specific setting. >>>>> + - mentor,num-eps : Specifies the number of endpoints. This is also a >>>>> + MUSB configuration-specific setting. Should be set to "8". >>>>> + - mentor,ram-bits : Specifies the ram address size. Should be set to "11". >>>>> + - mentor,power : Should be "500". This signifies the controller can supply >>>>> + up to 500mA when operating in host mode. >>>> >>>> No, these "nentor" prefixed parameters must be determined from the "compatible" prop. >>>> >>> Prefix "mentor" here is used to signify configuration of the MUSB controller IP, not >>> specifics of the chip or glue logic. >> >> I know. >> >>> Please suggest if replacing with "microchip" makes it better. >> >> No, nothing of that sort. These parameters are probably fixed for the said PIC32 implementation? If so, they shouldn't appear as the node props but should instead be hard-coded in the glue layer. Don't look at the OMAP glues, they are a bad example. > > ack. Will hard code. Except "mentor, power", that is. It was a part of the real platform data, not the MUSB config. structure. [...] > Thanks, Purna MBR, Sergei